Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F79539
D7507.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7507.diff
View Options
diff --git a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
--- a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
+++ b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
@@ -222,6 +222,7 @@
$response = new AphrontWebpageResponse();
$response->setContent($view->render());
+ $response->setHTTPResponseCode(500);
return $response;
}
@@ -268,6 +269,7 @@
$response = new AphrontDialogResponse();
$response->setDialog($dialog);
+ $response->setHTTPResponseCode(500);
return $response;
}
diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -249,9 +249,10 @@
$view->appendChild(hsprintf(
'<div style="padding: 2em 0;">%s</div>',
$response->buildResponseString()));
- $response = new AphrontWebpageResponse();
- $response->setContent($view->render());
- return $response;
+ $page_response = new AphrontWebpageResponse();
+ $page_response->setContent($view->render());
+ $page_response->setHTTPResponseCode($response->getHTTPResponseCode());
+ return $page_response;
} else {
$response->getDialog()->setIsStandalone(true);
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/sy/6l/w74qie3ikf5p62ij
Default Alt Text
D7507.diff (1 KB)
Attached To
Mode
D7507: Return HTTP 500, not HTTP 200, on exception pages
Attached
Detach File
Event Timeline
Log In to Comment