Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 6:24 PM
Unknown Object (File)
Sat, Nov 16, 7:37 AM
Unknown Object (File)
Thu, Nov 14, 5:44 AM
Unknown Object (File)
Thu, Nov 14, 5:19 AM
Unknown Object (File)
Thu, Nov 14, 3:22 AM
Unknown Object (File)
Wed, Nov 13, 3:24 AM
Unknown Object (File)
Mon, Nov 11, 10:18 PM
Unknown Object (File)
Sat, Nov 9, 11:02 PM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.