Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 11 2026, 3:01 PM
Unknown Object (File)
Feb 24 2026, 10:54 PM
Unknown Object (File)
Feb 8 2026, 11:31 PM
Unknown Object (File)
Feb 5 2026, 3:29 PM
Unknown Object (File)
Feb 2 2026, 10:34 PM
Unknown Object (File)
Jan 16 2026, 6:23 PM
Unknown Object (File)
Jan 15 2026, 6:32 PM
Unknown Object (File)
Jan 13 2026, 6:22 PM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.