Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
F18847334: D7507.diff
Thu, Oct 30, 12:05 AM
F18819620: D7507.id.diff
Wed, Oct 22, 7:36 AM
F18787416: D7507.diff
Oct 14 2025, 11:38 PM
F18621192: D7507.id16931.diff
Sep 15 2025, 7:20 AM
F18606419: D7507.id.diff
Sep 13 2025, 10:18 PM
F18597971: D7507.diff
Sep 13 2025, 4:05 AM
F18595810: D7507.diff
Sep 12 2025, 10:55 PM
F18581008: D7507.id16931.diff
Sep 11 2025, 5:01 AM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.