Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
F22618005: D7507.id16931.diff
Tue, Sep 29, 1:19 PM
Unknown Object (File)
Sat, Sep 12, 10:02 AM
Unknown Object (File)
Aug 15 2026, 12:08 AM
Unknown Object (File)
Jul 7 2026, 6:02 AM
Unknown Object (File)
Jun 17 2026, 12:15 AM
Unknown Object (File)
Jun 14 2026, 12:03 AM
Unknown Object (File)
Mar 11 2026, 3:01 PM
Unknown Object (File)
Feb 24 2026, 10:54 PM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.