Page MenuHomePhabricator

Return HTTP 500, not HTTP 200, on exception pages
ClosedPublic

Authored by epriestley on Nov 5 2013, 11:10 PM.
Tags
None
Referenced Files
F14034230: D7507.id16928.diff
Sat, Nov 9, 11:02 PM
F14026303: D7507.diff
Fri, Nov 8, 12:54 AM
F14018225: D7507.diff
Tue, Nov 5, 6:35 AM
F14005661: D7507.id16931.diff
Sun, Oct 27, 5:32 PM
F13994040: D7507.diff
Wed, Oct 23, 3:18 AM
F13971228: D7507.id.diff
Thu, Oct 17, 12:24 PM
Unknown Object (File)
Sep 12 2024, 6:35 AM
Unknown Object (File)
Sep 3 2024, 9:18 AM
Subscribers

Details

Summary

Ref T4064. The response code here isn't normally relevant, but we can hit these via git clone http://../, etc., and it's clearly more correct to use HTTP 500.

Test Plan

Added a fake throw new Exception() and verified I got an HTTP 500 response.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Unknown Object (User) added a comment.Nov 5 2013, 11:13 PM

Seems good, but I'll leave @btrahan to verify.