Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F74235
D7288.id16406.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7288.id16406.diff
View Options
diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php
--- a/src/__celerity_resource_map__.php
+++ b/src/__celerity_resource_map__.php
@@ -2586,7 +2586,7 @@
),
'javelin-magical-init' =>
array(
- 'uri' => '/res/7c6c8d5a/rsrc/externals/javelin/core/init.js',
+ 'uri' => '/res/374d1f02/rsrc/externals/javelin/core/init.js',
'type' => 'js',
'requires' =>
array(
diff --git a/webroot/rsrc/externals/javelin/core/init.js b/webroot/rsrc/externals/javelin/core/init.js
--- a/webroot/rsrc/externals/javelin/core/init.js
+++ b/webroot/rsrc/externals/javelin/core/init.js
@@ -67,13 +67,15 @@
for (var ii = 0; ii < local_queue.length; ++ii) {
var evt = local_queue[ii];
- // Sometimes IE gives us events which throw when ".type" is accessed;
- // just ignore them since we can't meaningfully dispatch them. TODO:
- // figure out where these are coming from.
+ // Sometimes IE gives us events which throw when ".type" is accessed;
+ // just ignore them since we can't meaningfully dispatch them. TODO:
+ // figure out where these are coming from.
try { var test = evt.type; } catch (x) { continue; }
if (!loaded && evt.type == 'domready') {
- document.body && (document.body.id = null);
+ // NOTE: Firefox interprets "document.body.id = null" as the string
+ // literal "null".
+ document.body && (document.body.id = '');
loaded = true;
for (var jj = 0; jj < onload.length; jj++) {
onload[jj]();
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/u6/l7/vmms3y6p3qu4gbgt
Default Alt Text
D7288.id16406.diff (1 KB)
Attached To
Mode
D7288: Improve an awkward initialization behavior in Javelin in Firefox
Attached
Detach File
Event Timeline
Log In to Comment