Page MenuHomePhabricator

Improve an awkward initialization behavior in Javelin in Firefox
ClosedPublic

Authored by epriestley on Oct 11 2013, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 7:09 AM
Unknown Object (File)
Sat, Jan 25, 2:15 AM
Unknown Object (File)
Fri, Jan 24, 5:45 AM
Unknown Object (File)
Fri, Jan 24, 5:45 AM
Unknown Object (File)
Fri, Jan 24, 5:33 AM
Unknown Object (File)
Mon, Jan 13, 8:13 PM
Unknown Object (File)
Sun, Jan 12, 2:18 AM
Unknown Object (File)
Jan 5 2025, 3:51 PM
Subscribers

Details

Summary

See comment; see IRC. This didn't cause anything bad, but ended up with document.body.id == "null" in Firefox, which is a bit weird.

Test Plan

Loaded page, put document.body.null into the console, got consistent results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
webroot/rsrc/externals/javelin/core/init.js
78

this line is a little weird in general with the && junk. yay firefox.