Page MenuHomePhabricator

Improve an awkward initialization behavior in Javelin in Firefox
ClosedPublic

Authored by epriestley on Oct 11 2013, 12:40 PM.
Tags
None
Referenced Files
F13212029: D7288.diff
Fri, May 17, 6:19 AM
F13197274: D7288.diff
Sun, May 12, 11:59 PM
Unknown Object (File)
Sat, May 4, 5:21 AM
Unknown Object (File)
Fri, May 3, 8:54 AM
Unknown Object (File)
Wed, Apr 24, 11:34 PM
Unknown Object (File)
Apr 11 2024, 10:10 AM
Unknown Object (File)
Apr 5 2024, 5:56 AM
Unknown Object (File)
Mar 19 2024, 1:43 AM
Subscribers

Details

Summary

See comment; see IRC. This didn't cause anything bad, but ended up with document.body.id == "null" in Firefox, which is a bit weird.

Test Plan

Loaded page, put document.body.null into the console, got consistent results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
webroot/rsrc/externals/javelin/core/init.js
78

this line is a little weird in general with the && junk. yay firefox.