Page MenuHomePhabricator

Improve an awkward initialization behavior in Javelin in Firefox
ClosedPublic

Authored by epriestley on Oct 11 2013, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 6:21 AM
Unknown Object (File)
Mon, Dec 9, 12:56 AM
Unknown Object (File)
Sun, Dec 8, 6:34 AM
Unknown Object (File)
Wed, Dec 4, 11:54 PM
Unknown Object (File)
Sat, Nov 30, 10:43 AM
Unknown Object (File)
Nov 27 2024, 11:52 AM
Unknown Object (File)
Nov 23 2024, 3:25 AM
Unknown Object (File)
Nov 22 2024, 4:39 AM
Subscribers

Details

Summary

See comment; see IRC. This didn't cause anything bad, but ended up with document.body.id == "null" in Firefox, which is a bit weird.

Test Plan

Loaded page, put document.body.null into the console, got consistent results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
webroot/rsrc/externals/javelin/core/init.js
78

this line is a little weird in general with the && junk. yay firefox.