Page MenuHomePhabricator

Improve an awkward initialization behavior in Javelin in Firefox
ClosedPublic

Authored by epriestley on Oct 11 2013, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 6, 4:17 PM
Unknown Object (File)
Wed, Apr 30, 3:34 AM
Unknown Object (File)
Apr 22 2025, 2:56 AM
Unknown Object (File)
Apr 16 2025, 11:19 PM
Unknown Object (File)
Mar 18 2025, 8:57 AM
Unknown Object (File)
Mar 11 2025, 1:34 AM
Unknown Object (File)
Feb 24 2025, 2:55 AM
Unknown Object (File)
Feb 9 2025, 8:22 AM
Subscribers

Details

Summary

See comment; see IRC. This didn't cause anything bad, but ended up with document.body.id == "null" in Firefox, which is a bit weird.

Test Plan

Loaded page, put document.body.null into the console, got consistent results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
webroot/rsrc/externals/javelin/core/init.js
78

this line is a little weird in general with the && junk. yay firefox.