Page MenuHomePhabricator

Improve an awkward initialization behavior in Javelin in Firefox
ClosedPublic

Authored by epriestley on Oct 11 2013, 12:40 PM.
Tags
None
Referenced Files
F15354003: D7288.id16420.diff
Tue, Mar 11, 1:34 AM
Unknown Object (File)
Mon, Feb 24, 2:55 AM
Unknown Object (File)
Feb 9 2025, 8:22 AM
Unknown Object (File)
Jan 30 2025, 7:09 AM
Unknown Object (File)
Jan 25 2025, 2:15 AM
Unknown Object (File)
Jan 24 2025, 5:45 AM
Unknown Object (File)
Jan 24 2025, 5:45 AM
Unknown Object (File)
Jan 24 2025, 5:33 AM
Subscribers

Details

Summary

See comment; see IRC. This didn't cause anything bad, but ended up with document.body.id == "null" in Firefox, which is a bit weird.

Test Plan

Loaded page, put document.body.null into the console, got consistent results.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan added inline comments.
webroot/rsrc/externals/javelin/core/init.js
78

this line is a little weird in general with the && junk. yay firefox.