D20311.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D20311.diff
View Options

	diff --git a/src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php b/src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php
	--- a/src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php
	+++ b/src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php
	@@ -55,11 +55,22 @@
	public function validateTransactions($object, array $xactions) {
	$errors = array();

	- $is_admin = $this->getActor()->getIsAdmin();
	+ $old = (bool)$object->getRequireSignature();
	+ foreach ($xactions as $xaction) {
	+ $new = (bool)$xaction->getNewValue();

	- if (!$is_admin) {
	- $errors[] = $this->newInvalidError(
	- pht('Only admins may require signature.'));
	+ if ($old === $new) {
	+ continue;
	+ }
	+
	+ $is_admin = $this->getActor()->getIsAdmin();
	+ if (!$is_admin) {
	+ $errors[] = $this->newInvalidError(
	+ pht(
	+ 'Only administrators may change whether a document '.
	+ 'requires a signature.'),
	+ $xaction);
	+ }
	}

	return $errors;