Page MenuHomePhabricator
Files F18809083

D12466.id29916.diff
No OneTemporary
Actions

D12466.id29916.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
*/
return array(
'names' => array(
- 'core.pkg.css' => 'd3651813',
+ 'core.pkg.css' => 'bf29d341',
'core.pkg.js' => '347cd64a',
'darkconsole.pkg.js' => '8ab24e01',
'differential.pkg.css' => '3500921f',
@@ -37,15 +37,15 @@
'rsrc/css/application/base/main-menu-view.css' => 'c648b2f5',
'rsrc/css/application/base/notification-menu.css' => '3c9d8aa1',
'rsrc/css/application/base/phabricator-application-launch-view.css' => '16ca323f',
- 'rsrc/css/application/base/standard-page-view.css' => 'd2a6518d',
+ 'rsrc/css/application/base/standard-page-view.css' => 'd3e1abe9',
'rsrc/css/application/chatlog/chatlog.css' => '852140ff',
'rsrc/css/application/config/config-options.css' => '7fedf08b',
'rsrc/css/application/config/config-template.css' => '8e6c6fcd',
'rsrc/css/application/config/config-welcome.css' => '6abd79be',
'rsrc/css/application/config/setup-issue.css' => '22270af2',
'rsrc/css/application/config/unhandled-exception.css' => '37d4f9a2',
- 'rsrc/css/application/conpherence/durable-column.css' => '51c1e074',
- 'rsrc/css/application/conpherence/menu.css' => 'f389e048',
+ 'rsrc/css/application/conpherence/durable-column.css' => '5faebda3',
+ 'rsrc/css/application/conpherence/menu.css' => '7c900089',
'rsrc/css/application/conpherence/message-pane.css' => '18ac5e85',
'rsrc/css/application/conpherence/notification.css' => 'd208f806',
'rsrc/css/application/conpherence/transaction.css' => '25138b7f',
@@ -110,7 +110,7 @@
'rsrc/css/core/core.css' => '76e8ee93',
'rsrc/css/core/remarkup.css' => 'e10512ff',
'rsrc/css/core/syntax.css' => '56c1ba38',
- 'rsrc/css/core/z-index.css' => 'd1a30710',
+ 'rsrc/css/core/z-index.css' => '72110fd4',
'rsrc/css/diviner/diviner-shared.css' => '38813222',
'rsrc/css/font/font-awesome.css' => 'ae9a7b4d',
'rsrc/css/font/font-source-sans-pro.css' => '4a2430d7',
@@ -518,8 +518,8 @@
'changeset-view-manager' => '58562350',
'config-options-css' => '7fedf08b',
'config-welcome-css' => '6abd79be',
- 'conpherence-durable-column-view' => '51c1e074',
- 'conpherence-menu-css' => 'f389e048',
+ 'conpherence-durable-column-view' => '5faebda3',
+ 'conpherence-menu-css' => '7c900089',
'conpherence-message-pane-css' => '18ac5e85',
'conpherence-notification-css' => 'd208f806',
'conpherence-thread-manager' => '0a5192c4',
@@ -752,7 +752,7 @@
'phabricator-side-menu-view-css' => '7e8c6341',
'phabricator-slowvote-css' => '266df6a1',
'phabricator-source-code-view-css' => '2ceee894',
- 'phabricator-standard-page-view' => 'd2a6518d',
+ 'phabricator-standard-page-view' => 'd3e1abe9',
'phabricator-textareautils' => '5c93c52c',
'phabricator-title' => 'df5e11d2',
'phabricator-tooltip' => '1d298e3a',
@@ -767,7 +767,7 @@
'phabricator-uiexample-reactor-select' => 'a155550f',
'phabricator-uiexample-reactor-sendclass' => '1def2711',
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
- 'phabricator-zindex-css' => 'd1a30710',
+ 'phabricator-zindex-css' => '72110fd4',
'phame-css' => '88bd4705',
'pholio-css' => '95174bdd',
'pholio-edit-css' => '3ad9d1ee',
diff --git a/src/view/page/PhabricatorStandardPageView.php b/src/view/page/PhabricatorStandardPageView.php
--- a/src/view/page/PhabricatorStandardPageView.php
+++ b/src/view/page/PhabricatorStandardPageView.php
@@ -365,7 +365,6 @@
if ($user && $user->getIsAdmin()) {
$open = PhabricatorSetupCheck::getOpenSetupIssueKeys();
if ($open) {
- $classes[] = 'page-has-warning';
$setup_warning = phutil_tag_div(
'setup-warning-callout',
phutil_tag(
@@ -392,7 +391,9 @@
'class' => 'phabricator-standard-page',
),
array(
+ $developer_warning,
$header_chrome,
+ $setup_warning,
phutil_tag(
'div',
array(
@@ -422,8 +423,6 @@
'class' => implode(' ', $classes),
),
array(
- $developer_warning,
- $setup_warning,
$main_page,
$durable_column,
));
diff --git a/webroot/rsrc/css/application/base/standard-page-view.css b/webroot/rsrc/css/application/base/standard-page-view.css
--- a/webroot/rsrc/css/application/base/standard-page-view.css
+++ b/webroot/rsrc/css/application/base/standard-page-view.css
@@ -111,9 +111,14 @@
}
.setup-warning-callout {
- position: relative;
padding: 8px 16px;
- background: {$lightyellow};
+ background: {$lightred};
+ border-bottom: 1px solid {$sh-redborder};
+ position: relative;
+}
+
+.setup-warning-callout a {
+ color: {$red};
}
.phui-handle .phui-icon-view {
diff --git a/webroot/rsrc/css/application/conpherence/durable-column.css b/webroot/rsrc/css/application/conpherence/durable-column.css
--- a/webroot/rsrc/css/application/conpherence/durable-column.css
+++ b/webroot/rsrc/css/application/conpherence/durable-column.css
@@ -29,10 +29,6 @@
background: #fff;
}
-.page-has-warning .conpherence-durable-column {
- top: 32px;
-}
-
.conpherence-durable-column .loading-mask {
position: absolute;
top: 90px;
diff --git a/webroot/rsrc/css/application/conpherence/menu.css b/webroot/rsrc/css/application/conpherence/menu.css
--- a/webroot/rsrc/css/application/conpherence/menu.css
+++ b/webroot/rsrc/css/application/conpherence/menu.css
@@ -11,10 +11,6 @@
background: #fff;
}
-.page-has-warning .conpherence-layout {
- top: 76px;
-}
-
.conpherence-layout .conpherence-no-threads {
text-align: center;
position: fixed;
diff --git a/webroot/rsrc/css/core/z-index.css b/webroot/rsrc/css/core/z-index.css
--- a/webroot/rsrc/css/core/z-index.css
+++ b/webroot/rsrc/css/core/z-index.css
@@ -6,6 +6,7 @@
z-index: -1;
}
+.setup-warning-callout,
.keyboard-focus-focus-reticle {
z-index: 1;
}
@@ -86,7 +87,6 @@
z-index: 6;
}
-.setup-warning-callout,
.aphront-developer-error-callout {
z-index: 6;
}

File Metadata

Mime Type
text/plain
Expires
Oct 20 2025, 11:03 AM (5 w, 23 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9301145
Default Alt Text
D12466.id29916.diff (6 KB)

Event Timeline

Phabricator · Built by Phacility