Page MenuHomePhabricator

Move setup issue callout to under the header
ClosedPublic

Authored by chad on Apr 19 2015, 4:08 AM.

Details

Summary

Fixes T7830. Moves the callout to sit under the main header, which resolved Differential issues and Durable Column issues, but still some extra CSS shenanigans.

Test Plan

Test lots of pages, Home, Dashboards, Conpherence, Durable Column, Inline Diff Replies, Mobile, Workboards, etc.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad retitled this revision from to Move setup issue callout to under the header.Apr 19 2015, 4:08 AM
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad updated this revision to Diff 29916.
chad edited the test plan for this revision. (Show Details)Apr 19 2015, 4:09 AM
chad updated this revision to Diff 29917.Apr 19 2015, 4:13 AM
  • Conpherence was still funky
chad updated this revision to Diff 29918.Apr 19 2015, 4:15 AM
  • Well I don't know what the fuck I'm doing
chad updated this object.Apr 19 2015, 4:16 AM
chad added a comment.Apr 19 2015, 4:20 AM

I'm going to go play Hearthstone

chad updated this revision to Diff 29919.Apr 19 2015, 4:46 AM
  • moar conphencerecence
chad added a comment.Apr 19 2015, 4:49 AM

Resolved a number of non-obvious Conpherence bugs with the current iteration as well.

chad added a comment.Apr 19 2015, 4:50 AM

Going back to Hearthstone.

epriestley edited edge metadata.Apr 19 2015, 12:50 PM
epriestley accepted this revision.

I still favor just making this a menu item, but if this solves all problems forever...

This revision is now accepted and ready to land.Apr 19 2015, 12:50 PM
chad added a comment.Apr 19 2015, 2:15 PM

my only concern with a menu item is it would be non-obvious and very ignorable. maybe some future Rooster System?

I am willing to say this is my last attempt before moving it somewhere else.

This revision was automatically updated to reflect the committed changes.

I'm not above making it flicker rapidly or giving it an animation.