Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18804314
D21433.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D21433.diff
View Options
diff --git a/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php b/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
@@ -83,7 +83,9 @@
$cells = array();
if ($is_old) {
if ($p['htype']) {
- if (empty($p['oline'])) {
+ if ($p['htype'] === '\\') {
+ $class = 'comment';
+ } else if (empty($p['oline'])) {
$class = 'left old old-full';
} else {
$class = 'left old';
@@ -129,7 +131,9 @@
$cells[] = $no_coverage;
} else {
if ($p['htype']) {
- if (empty($p['oline'])) {
+ if ($p['htype'] === '\\') {
+ $class = 'comment';
+ } else if (empty($p['oline'])) {
$class = 'right new new-full';
} else {
$class = 'right new';
diff --git a/src/applications/differential/render/DifferentialChangesetRenderer.php b/src/applications/differential/render/DifferentialChangesetRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetRenderer.php
@@ -505,6 +505,8 @@
$ospec['htype'] = $old[$ii]['type'];
if (isset($old_render[$ii])) {
$ospec['render'] = $old_render[$ii];
+ } else if ($ospec['htype'] === '\\') {
+ $ospec['render'] = $old[$ii]['text'];
}
}
@@ -514,6 +516,8 @@
$nspec['htype'] = $new[$ii]['type'];
if (isset($new_render[$ii])) {
$nspec['render'] = $new_render[$ii];
+ } else if ($nspec['htype'] === '\\') {
+ $nspec['render'] = $new[$ii]['text'];
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Oct 19, 7:19 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8540787
Default Alt Text
D21433.diff (1 KB)
Attached To
Mode
D21433: In 1-up source diffs, retain the "No newline at end of file" on "\" lines
Attached
Detach File
Event Timeline
Log In to Comment