Page MenuHomePhabricator

D16487.diff
No OneTemporary

D16487.diff

diff --git a/src/applications/diviner/atomizer/DivinerPHPAtomizer.php b/src/applications/diviner/atomizer/DivinerPHPAtomizer.php
--- a/src/applications/diviner/atomizer/DivinerPHPAtomizer.php
+++ b/src/applications/diviner/atomizer/DivinerPHPAtomizer.php
@@ -141,7 +141,7 @@
$docs = idx($metadata, 'param');
if ($docs) {
- $docs = explode("\n", $docs);
+ $docs = (array)$docs;
$docs = array_filter($docs);
} else {
$docs = array();
@@ -283,6 +283,15 @@
}
}
+ $return = (array)$return;
+ if (count($return) > 1) {
+ $atom->addWarning(
+ pht(
+ 'Documentation specifies `%s` multiple times.',
+ '@return'));
+ }
+ $return = head($return);
+
if ($atom->getName() == '__construct' && $atom->getType() == 'method') {
$return_spec = array(
'doctype' => 'this',

File Metadata

Mime Type
text/plain
Expires
Aug 13 2025, 7:41 AM (10 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
9195320
Default Alt Text
D16487.diff (882 B)

Event Timeline