Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F18109457
D21462.id51090.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
788 B
Referenced Files
None
Subscribers
None
D21462.id51090.diff
View Options
diff --git a/src/applications/differential/query/DifferentialRevisionQuery.php b/src/applications/differential/query/DifferentialRevisionQuery.php
--- a/src/applications/differential/query/DifferentialRevisionQuery.php
+++ b/src/applications/differential/query/DifferentialRevisionQuery.php
@@ -778,12 +778,19 @@
*/
protected function shouldGroupQueryResultRows() {
- $join_triggers = array_merge(
- $this->pathIDs,
- $this->ccs,
- $this->reviewers);
+ if (count($this->pathIDs) > 1) {
+ return true;
+ }
+
+ if (count($this->ccs) > 1) {
+ return true;
+ }
+
+ if (count($this->reviewers) > 1) {
+ return true;
+ }
- if (count($join_triggers) > 1) {
+ if (count($this->commitHashes) > 1) {
return true;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Aug 12, 1:47 PM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8791890
Default Alt Text
D21462.id51090.diff (788 B)
Attached To
Mode
D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes
Attached
Detach File
Event Timeline
Log In to Comment