Files F18104430

D19263.id46114.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D19263.id46114.diff
View Options

	diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
	@@ -1120,6 +1120,11 @@
	// We are the Herald editor, so stop work here and return the updated
	// transactions.
	return $xactions;
	+ } else if ($this->getIsInverseEdgeEditor()) {
	+ // Do not run Herald if we're just recording that this object was
	+ // mentioned elsewhere. This tends to create Herald side effects which
	+ // feel arbitrary, and can really slow down edits which mention a large
	+ // number of other objects. See T13114.
	} else if ($this->shouldApplyHeraldRules($object, $xactions)) {
	// We are not the Herald editor, so try to apply Herald rules.
	$herald_xactions = $this->applyHeraldRules($object, $xactions);

File Metadata

Mime Type: text/plain
Expires: Aug 11 2025, 12:19 PM (10 w, 19 h ago)
Storage Engine: blob
Storage Format: Encrypted (AES-256-CBC)
Storage Handle: 8683797
Default Alt Text: D19263.id46114.diff (1 KB)

Event Timeline