Page MenuHomePhabricator
Differential D19263

Stop evaluating Herald rules when writing "someone mentioned this somewhere else." transactions
ClosedPublic
Actions

Authored by epriestley on Mar 28 2018, 10:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:47 AM
Unknown Object (File)
Fri, Apr 19, 7:36 PM
Unknown Object (File)
Wed, Apr 17, 2:53 PM
Unknown Object (File)
Tue, Apr 9, 11:50 AM
Unknown Object (File)
Mon, Apr 1, 1:56 AM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13114: Plans: 2018 Week 13 Bonus Content
Commits
rPb586ee065a75: Stop evaluating Herald rules when writing "someone mentioned this somewhere…
Summary

Ref T13114. See PHI510. Firing Herald on mentioned objects tends to feel arbitrary and can substantially slow down edits which mention many objects.

Test Plan

Mentioned tasks on other tasks; verified that the normal path is hit normally, the new Herald-free path is hit on the mentioned object, and both still work fine and show up in the timeline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 28 2018, 10:24 PM
Harbormaster completed remote builds in B19935: Diff 46113.Mar 28 2018, 10:25 PM
epriestley requested review of this revision.Mar 28 2018, 10:25 PM
epriestley added a comment.Mar 28 2018, 10:27 PM

Although I'm focusing on "mentions" here, "inverse edge edits" apply more broadly to any situation where an object is the far end of a link, so Ref Xyz., Fixes Xyz., Depends on Dxxx., "Edit Parent Tasks", etc. will also hit this logic. I think this is appropriate in all cases -- it doesn't feel to me like any of these "another object is now related to this object somehow" changes should be firing Herald updates on the target.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2018, 10:35 PM
Closed by commit rPb586ee065a75: Stop evaluating Herald rules when writing "someone mentioned this somewhere… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
editor/
5 lines

Diff 46114

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility