Page MenuHomePhabricator

D9898.id23763.diff
No OneTemporary

D9898.id23763.diff

diff --git a/src/repository/api/ArcanistGitAPI.php b/src/repository/api/ArcanistGitAPI.php
--- a/src/repository/api/ArcanistGitAPI.php
+++ b/src/repository/api/ArcanistGitAPI.php
@@ -429,17 +429,20 @@
* @param head revision. If this is null, the generated diff will include the
* working copy
*/
- public function getFullGitDiff($base, $head=null) {
+ public function getFullGitDiff($base, $head = null) {
$options = $this->getDiffFullOptions();
- $diff_revision = $base;
- if ($head) {
- $diff_revision .= '..'.$head;
+ if ($head !== null) {
+ list($stdout) = $this->execxLocal(
+ "diff {$options} %s %s --",
+ $base,
+ $head);
+ } else {
+ list($stdout) = $this->execxLocal(
+ "diff {$options} %s --",
+ $base);
}
- list($stdout) = $this->execxLocal(
- "diff {$options} %s --",
- $diff_revision);
return $stdout;
}

File Metadata

Mime Type
text/plain
Expires
Aug 2 2025, 2:21 AM (5 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8757033
Default Alt Text
D9898.id23763.diff (931 B)

Event Timeline