Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F17952786
D9898.id23763.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
931 B
Referenced Files
None
Subscribers
None
D9898.id23763.diff
View Options
diff --git a/src/repository/api/ArcanistGitAPI.php b/src/repository/api/ArcanistGitAPI.php
--- a/src/repository/api/ArcanistGitAPI.php
+++ b/src/repository/api/ArcanistGitAPI.php
@@ -429,17 +429,20 @@
* @param head revision. If this is null, the generated diff will include the
* working copy
*/
- public function getFullGitDiff($base, $head=null) {
+ public function getFullGitDiff($base, $head = null) {
$options = $this->getDiffFullOptions();
- $diff_revision = $base;
- if ($head) {
- $diff_revision .= '..'.$head;
+ if ($head !== null) {
+ list($stdout) = $this->execxLocal(
+ "diff {$options} %s %s --",
+ $base,
+ $head);
+ } else {
+ list($stdout) = $this->execxLocal(
+ "diff {$options} %s --",
+ $base);
}
- list($stdout) = $this->execxLocal(
- "diff {$options} %s --",
- $diff_revision);
return $stdout;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Aug 2 2025, 2:21 AM (5 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8757033
Default Alt Text
D9898.id23763.diff (931 B)
Attached To
Mode
D9898: Use `git diff a b` for ranges, not `git diff a..b`
Attached
Detach File
Event Timeline
Log In to Comment