Page MenuHomePhabricator

D14243.id34392.diff
No OneTemporary

D14243.id34392.diff

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -13,7 +13,7 @@
'differential.pkg.css' => '2de124c9',
'differential.pkg.js' => '6223dd9d',
'diffusion.pkg.css' => 'f45955ed',
- 'diffusion.pkg.js' => '0115b37c',
+ 'diffusion.pkg.js' => 'ca1c8b5a',
'maniphest.pkg.css' => '4845691a',
'maniphest.pkg.js' => '3ec6a6d5',
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
@@ -371,7 +371,7 @@
'rsrc/js/application/diffusion/behavior-jump-to.js' => '73d09eef',
'rsrc/js/application/diffusion/behavior-load-blame.js' => '42126667',
'rsrc/js/application/diffusion/behavior-locate-file.js' => '6d3e1947',
- 'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => '2b228192',
+ 'rsrc/js/application/diffusion/behavior-pull-lastmodified.js' => 'f01586dc',
'rsrc/js/application/doorkeeper/behavior-doorkeeper-tag.js' => 'e5822781',
'rsrc/js/application/files/behavior-icon-composer.js' => '8ef9ab58',
'rsrc/js/application/files/behavior-launch-icon-composer.js' => '48086888',
@@ -574,7 +574,7 @@
'javelin-behavior-diffusion-commit-graph' => '9007c197',
'javelin-behavior-diffusion-jump-to' => '73d09eef',
'javelin-behavior-diffusion-locate-file' => '6d3e1947',
- 'javelin-behavior-diffusion-pull-lastmodified' => '2b228192',
+ 'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc',
'javelin-behavior-doorkeeper-tag' => 'e5822781',
'javelin-behavior-durable-column' => 'c72aa091',
'javelin-behavior-error-log' => '6882e80a',
@@ -998,13 +998,6 @@
'javelin-install',
'javelin-util',
),
- '2b228192' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-util',
- 'javelin-workflow',
- 'javelin-json',
- ),
'2b8de964' => array(
'javelin-install',
'javelin-util',
@@ -1939,6 +1932,13 @@
'javelin-install',
'javelin-util',
),
+ 'f01586dc' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-util',
+ 'javelin-workflow',
+ 'javelin-json',
+ ),
'f24a53cb' => array(
'phui-fontkit-css',
),
diff --git a/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js b/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js
--- a/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js
+++ b/webroot/rsrc/js/application/diffusion/behavior-pull-lastmodified.js
@@ -16,7 +16,16 @@
if (!config.map[k][l]) {
continue;
}
- JX.DOM.setContent(JX.$(config.map[k][l]), JX.$H(r[k][l]));
+ try {
+ JX.DOM.setContent(JX.$(config.map[k][l]), JX.$H(r[k][l]));
+ } catch (ex) {
+ // The way this works is weird and sometimes the components get
+ // out of sync. Fail gently until we can eventually improve the
+ // underlying mechanism.
+
+ // In particular, we currently may generate lint information
+ // without generating a lint column. See T9524.
+ }
}
}
})

File Metadata

Mime Type
text/plain
Expires
Fri, Jul 11, 4:23 AM (2 w, 21 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
8297060
Default Alt Text
D14243.id34392.diff (3 KB)

Event Timeline