Page MenuHomePhabricator

Make Diffusion "Last Modified" rendering less fragile
ClosedPublic

Authored by epriestley on Oct 7 2015, 12:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:33 AM
Unknown Object (File)
Tue, Apr 2, 10:24 PM
Unknown Object (File)
Thu, Mar 28, 9:10 PM
Unknown Object (File)
Mar 22 2024, 7:47 AM
Unknown Object (File)
Mar 14 2024, 11:45 AM
Unknown Object (File)
Mar 4 2024, 6:33 PM
Unknown Object (File)
Mar 4 2024, 6:33 PM
Unknown Object (File)
Mar 4 2024, 6:33 PM
Subscribers
None

Details

Summary

Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax.

The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ.

In particular, calling diffusion.updatecoverage can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one).

In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes.

Test Plan

Reproduced the issue in T9524 by calling diffusion.updatecoverage on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of.

Applied this patch, got a clean render.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make Diffusion "Last Modified" rendering less fragile.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 7 2015, 2:26 PM
This revision was automatically updated to reflect the committed changes.