Page MenuHomePhabricator
Files F15515768

D20507.diff
No OneTemporary
Actions

D20507.diff
View Options

diff --git a/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php b/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
@@ -55,4 +55,15 @@
}
}
+ public function getTransactionTypeForConduit($xaction) {
+ return 'draft';
+ }
+
+ public function getFieldValuesForConduit($xaction, $data) {
+ return array(
+ 'old' => $xaction->getOldValue(),
+ 'new' => $xaction->getNewValue(),
+ );
+ }
+
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionSummaryTransaction.php b/src/applications/differential/xaction/DifferentialRevisionSummaryTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionSummaryTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionSummaryTransaction.php
@@ -61,4 +61,15 @@
pht('Summary'));
}
+ public function getTransactionTypeForConduit($xaction) {
+ return 'summary';
+ }
+
+ public function getFieldValuesForConduit($xaction, $data) {
+ return array(
+ 'old' => $xaction->getOldValue(),
+ 'new' => $xaction->getNewValue(),
+ );
+ }
+
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php b/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionTestPlanTransaction.php
@@ -75,4 +75,15 @@
return $errors;
}
+ public function getTransactionTypeForConduit($xaction) {
+ return 'testPlan';
+ }
+
+ public function getFieldValuesForConduit($xaction, $data) {
+ return array(
+ 'old' => $xaction->getOldValue(),
+ 'new' => $xaction->getNewValue(),
+ );
+ }
+
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php b/src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php
@@ -59,10 +59,10 @@
return 'title';
}
- public function getFieldValuesForConduit($object, $data) {
+ public function getFieldValuesForConduit($xaction, $data) {
return array(
- 'old' => $object->getOldValue(),
- 'new' => $object->getNewValue(),
+ 'old' => $xaction->getOldValue(),
+ 'new' => $xaction->getNewValue(),
);
}
diff --git a/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php b/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
@@ -225,12 +225,12 @@
return 'update';
}
- public function getFieldValuesForConduit($object, $data) {
- $commit_phids = $object->getMetadataValue('commitPHIDs', array());
+ public function getFieldValuesForConduit($xaction, $data) {
+ $commit_phids = $xaction->getMetadataValue('commitPHIDs', array());
return array(
- 'old' => $object->getOldValue(),
- 'new' => $object->getNewValue(),
+ 'old' => $xaction->getOldValue(),
+ 'new' => $xaction->getNewValue(),
'commitPHIDs' => $commit_phids,
);
}

File Metadata

Mime Type
text/plain
Expires
Sat, Apr 19, 1:08 PM (5 d, 12 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7681756
Default Alt Text
D20507.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility