Page MenuHomePhabricator

D7708.diff
No OneTemporary

D7708.diff

Index: src/applications/harbormaster/controller/HarbormasterPlanViewController.php
===================================================================
--- src/applications/harbormaster/controller/HarbormasterPlanViewController.php
+++ src/applications/harbormaster/controller/HarbormasterPlanViewController.php
@@ -86,7 +86,31 @@
$step_list = id(new PHUIObjectItemListView())
->setUser($viewer);
foreach ($steps as $step) {
- $implementation = $step->getStepImplementation();
+ $implementation = null;
+ try {
+ $implementation = $step->getStepImplementation();
+ } catch (Exception $ex) {
+ // We can't initialize the implementation. This might be because
+ // it's been renamed or no longer exists.
+ $item = id(new PHUIObjectItemView())
+ ->setObjectName("Step ".$i++)
+ ->setHeader(pht('Unknown Implementation'))
+ ->setBarColor('red')
+ ->addAttribute(pht(
+ 'This step has an invalid implementation (%s).',
+ $step->getClassName()))
+ ->addAction(
+ id(new PHUIListItemView())
+ ->setIcon('delete')
+ ->addSigil('harbormaster-build-step-delete')
+ ->setWorkflow(true)
+ ->setRenderNameAsTooltip(true)
+ ->setName(pht("Delete"))
+ ->setHref(
+ $this->getApplicationURI("step/delete/".$step->getID()."/")));
+ $step_list->addItem($item);
+ continue;
+ }
$item = id(new PHUIObjectItemView())
->setObjectName("Step ".$i++)
->setHeader($implementation->getName());

File Metadata

Mime Type
text/plain
Expires
Sat, Apr 19, 7:49 AM (5 d, 8 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7687663
Default Alt Text
D7708.diff (1 KB)

Event Timeline