Make "Edit Build Plan" more resiliant so old build configurations can be deleted
ClosedPublic
Actions

Authored by hach-que on Dec 5 2013, 3:17 AM.

Tags

None

Referenced Files

	F15458171: D7708.id17410.diff
	Sun, Mar 30, 9:26 PM

	F15437207: D7708.id.diff
	Tue, Mar 25, 6:19 PM

	F15435830: D7708.id17411.diff
	Tue, Mar 25, 10:28 AM

	F15429984: D7708.diff
	Mon, Mar 24, 5:09 AM

	F15415392: D7708.id17411.diff
	Thu, Mar 20, 5:45 AM

	F15381597: D7708.id.diff
	Fri, Mar 14, 8:32 AM

	Unknown Object (File)
	Feb 24 2025, 11:17 AM

	Unknown Object (File)
	Feb 13 2025, 8:25 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4111: Use Drydock to allocate build machines for Harbormaster
T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rPa8b27130cbcd: Make "Edit Build Plan" more resiliant so old build configurations can be deleted

Summary

Currently the "Edit Build Plan" page crashes if there are any build steps with invalid implementations (because the implementation class has been removed or renamed). This updates the Edit Build Plan page so that steps with invalid implementations can be deleted.

Test Plan

Looked at a build plan with invalid configurations and deleted it's steps.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Seems reasonable to me.

src/applications/harbormaster/controller/HarbormasterPlanViewController.php
99	Maybe put the (presumed bad) implementation class into the message? Might help debug things.

Closed by commit rPa8b27130cbcd (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterPlanViewController.php

26 lines

Diff 17411

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Make "Edit Build Plan" more resiliant so old build configurations can be deletedClosedPublicActions