Make "Edit Build Plan" more resiliant so old build configurations can be deleted
ClosedPublic
Actions

Authored by hach-que on Dec 5 2013, 3:17 AM.

Tags

None

Referenced Files

	F19236494: D7708.id17411.diff
	Sun, Dec 21, 7:11 PM

	F19084985: D7708.id.diff
	Tue, Dec 2, 4:59 PM

	F19084800: D7708.id.diff
	Tue, Dec 2, 4:21 PM

	F19074077: D7708.diff
	Mon, Dec 1, 4:14 AM

	F19016271: D7708.diff
	Nov 23 2025, 3:26 AM

	F18851800: D7708.diff
	Oct 31 2025, 4:20 AM

	F18777624: D7708.id.diff
	Oct 11 2025, 3:57 AM

	F18756702: D7708.id17411.diff
	Oct 5 2025, 12:51 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4111: Use Drydock to allocate build machines for Harbormaster
T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rPa8b27130cbcd: Make "Edit Build Plan" more resiliant so old build configurations can be deleted

Summary

Currently the "Edit Build Plan" page crashes if there are any build steps with invalid implementations (because the implementation class has been removed or renamed). This updates the Edit Build Plan page so that steps with invalid implementations can be deleted.

Test Plan

Looked at a build plan with invalid configurations and deleted it's steps.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Seems reasonable to me.

src/applications/harbormaster/controller/HarbormasterPlanViewController.php
99	Maybe put the (presumed bad) implementation class into the message? Might help debug things.

Closed by commit rPa8b27130cbcd (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterPlanViewController.php

26 lines

Diff 17411

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Make "Edit Build Plan" more resiliant so old build configurations can be deletedClosedPublicActions