Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15513794
D21059.id50172.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1010 B
Referenced Files
None
Subscribers
None
D21059.id50172.diff
View Options
diff --git a/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php b/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php
@@ -38,6 +38,14 @@
$changeset = $data[$comment->getChangesetID()];
$diff = $changeset->getDiff();
+ $is_done = false;
+ switch ($comment->getFixedState()) {
+ case PhabricatorInlineCommentInterface::STATE_DONE:
+ case PhabricatorInlineCommentInterface::STATE_UNDRAFT:
+ $is_done = true;
+ break;
+ }
+
return array(
'diff' => array(
'id' => (int)$diff->getID(),
@@ -47,6 +55,7 @@
'line' => (int)$comment->getLineNumber(),
'length' => (int)($comment->getLineLength() + 1),
'replyToCommentPHID' => $comment->getReplyToCommentPHID(),
+ 'isDone' => $is_done,
);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Apr 18, 9:55 PM (4 d, 21 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7709512
Default Alt Text
D21059.id50172.diff (1010 B)
Attached To
Mode
D21059: Add an "isDone" flag to "transaction.search" for Differential inline comments
Attached
Detach File
Event Timeline
Log In to Comment