Add an "isDone" flag to "transaction.search" for Differential inline comments
ClosedPublic
Actions

Authored by epriestley on Apr 5 2020, 4:03 PM.

Tags

None

Referenced Files

	F15513794: D21059.id50172.diff
	Thu, Apr 17, 9:55 PM

	F15481935: D21059.id50172.diff
	Wed, Apr 9, 12:59 AM

	F15460081: D21059.id.diff
	Mar 31 2025, 8:02 PM

	F15457079: D21059.diff
	Mar 30 2025, 2:13 PM

	F15451675: D21059.diff
	Mar 28 2025, 11:17 PM

	F15449262: D21059.id.diff
	Mar 28 2025, 9:12 AM

	F15440456: D21059.id50173.diff
	Mar 26 2025, 12:54 PM

	F15422516: D21059.id50173.diff
	Mar 22 2025, 9:05 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline…
rPf1d1ec3d77f1: Add an "isDone" flag to "transaction.search" for Differential inline comments

Summary

See PHI1684. Expose the published state of the "Done" checkbox to the API.

Test Plan

Made API calls on a comment in all four states, got correct published states via the API in all cases.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 5 2020, 4:03 PM

Harbormaster completed remote builds in B23991: Diff 50172.Apr 5 2020, 4:05 PM

epriestley requested review of this revision.Apr 5 2020, 4:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 5 2020, 4:36 PM

Closed by commit rPf1d1ec3d77f1: Add an "isDone" flag to "transaction.search" for Differential inline comments (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf1d1ec3d77f1: Add an "isDone" flag to "transaction.search" for Differential inline comments.

epriestley added a commit: rPff348b40f937: (stable) Add an "isDone" flag to "transaction.search" for Differential inline….

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionInlineTransaction.php

9 lines

Diff 50173

View Options

src/applications/differential/xaction/DifferentialRevisionInlineTransaction.php

Add an "isDone" flag to "transaction.search" for Differential inline commentsClosedPublicActions