D17545.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D17545.diff
View Options

	diff --git a/src/applications/audit/query/PhabricatorCommitSearchEngine.php b/src/applications/audit/query/PhabricatorCommitSearchEngine.php
	--- a/src/applications/audit/query/PhabricatorCommitSearchEngine.php
	+++ b/src/applications/audit/query/PhabricatorCommitSearchEngine.php
	@@ -178,10 +178,13 @@
	$groups = $bucket->newResultGroups($query, $commits);

	foreach ($groups as $group) {
	- $views[] = id(clone $template)
	- ->setHeader($group->getName())
	- ->setNoDataString($group->getNoDataString())
	- ->setCommits($group->getObjects());
	+ // Don't show groups in Dashboard Panels
	+ if ($group->getObjects() \|\| !$this->isPanelContext()) {
	+ $views[] = id(clone $template)
	+ ->setHeader($group->getName())
	+ ->setNoDataString($group->getNoDataString())
	+ ->setCommits($group->getObjects());
	+ }
	}
	} catch (Exception $ex) {
	$this->addError($ex->getMessage());
	@@ -189,7 +192,13 @@
	} else {
	$views[] = id(clone $template)
	->setCommits($commits)
	- ->setNoDataString(pht('No matching commits.'));
	+ ->setNoDataString(pht('No commits found.'));
	+ }
	+
	+ if (!$views) {
	+ $views[] = id(new PhabricatorAuditListView())
	+ ->setViewer($viewer)
	+ ->setNoDataString(pht('No commits found.'));
	}

	if (count($views) == 1) {