Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15482351
D19692.id47046.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D19692.id47046.diff
View Options
Index: externals/includes/README
===================================================================
--- externals/includes/README
+++ /dev/null
@@ -1,3 +0,0 @@
-This directory is added to the PHP include path. You can symlink things here
-if you have control over directory setup but not over PHP configuration (for
-instance, in Homebrew).
Index: support/ArcanistRuntime.php
===================================================================
--- support/ArcanistRuntime.php
+++ support/ArcanistRuntime.php
@@ -8,11 +8,6 @@
return $err;
}
- $err = $this->includeCoreLibraries();
- if ($err) {
- return $err;
- }
-
PhutilTranslator::getInstance()
->setLocale(PhutilLocale::loadLocale('en_US'))
->setTranslations(PhutilTranslation::getTranslationMapForLocale('en_US'));
@@ -26,6 +21,7 @@
"**%s:** %s\n",
pht('Usage Exception'),
$ex->getMessage()));
+
return 77;
}
}
@@ -207,45 +203,6 @@
return 1;
}
- private function includeCoreLibraries() {
- // Adjust 'include_path' to add locations where we'll search for libphutil.
- // We look in these places:
- //
- // - Next to 'arcanist/'.
- // - Anywhere in the normal PHP 'include_path'.
- // - Inside 'arcanist/externals/includes/'.
- //
- // When looking in these places, we expect to find a 'libphutil/' directory.
-
- // The 'arcanist/' directory.
- $arcanist_dir = dirname(dirname(__FILE__));
-
- // The parent directory of 'arcanist/'.
- $parent_dir = dirname($arcanist_dir);
-
- // The 'arcanist/externals/includes/' directory.
- $include_dir = implode(
- DIRECTORY_SEPARATOR,
- array(
- $arcanist_dir,
- 'externals',
- 'includes',
- ));
-
- $php_include_path = ini_get('include_path');
- $php_include_path = implode(
- PATH_SEPARATOR,
- array(
- $parent_dir,
- $php_include_path,
- $include_dir,
- ));
-
- ini_set('include_path', $php_include_path);
-
- return 0;
- }
-
private function loadConfiguration(PhutilArgumentParser $args) {
$configuration_manager = new ArcanistConfigurationManager();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Apr 10, 4:48 AM (1 w, 6 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7726336
Default Alt Text
D19692.id47046.diff (2 KB)
Attached To
Mode
D19692: [Wilds] Remove include_path mangling and drop support for "externals/includes"
Attached
Detach File
Event Timeline
Log In to Comment