Page MenuHomePhabricator

[Wilds] Remove include_path mangling and drop support for "externals/includes"
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:07 PM.

Details

Summary

Ref T13098. This logic comes from D3243 and was theoretically used to let you install libphutil with Homebrew. Since libphutil no longer exists and the other use cases I can come up with are questionable/obsolete, remove it.

(As we move into T5055, I expect to provide better tools for bundling/managing external dependencies.)

Test Plan

Ran arc, same as the old arc.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley requested review of this revision.Sep 18 2018, 8:07 PM
epriestley created this revision.
amckinley accepted this revision.Sep 20 2018, 12:17 AM
This revision is now accepted and ready to land.Sep 20 2018, 12:17 AM
This revision was automatically updated to reflect the committed changes.