Page MenuHomePhabricator

[Wilds] Remove include_path mangling and drop support for "externals/includes"
ClosedPublic

Authored by epriestley on Sep 18 2018, 8:07 PM.
Tags
None
Referenced Files
F14026960: D19692.diff
Fri, Nov 8, 4:00 AM
F13991274: D19692.id47063.diff
Tue, Oct 22, 9:43 AM
F13982509: D19692.id.diff
Sat, Oct 19, 11:50 PM
F13972418: D19692.diff
Thu, Oct 17, 6:53 PM
Unknown Object (File)
Oct 9 2024, 10:10 AM
Unknown Object (File)
Oct 9 2024, 10:10 AM
Unknown Object (File)
Oct 9 2024, 10:10 AM
Unknown Object (File)
Oct 7 2024, 9:27 PM
Subscribers
None

Details

Summary

Ref T13098. This logic comes from D3243 and was theoretically used to let you install libphutil with Homebrew. Since libphutil no longer exists and the other use cases I can come up with are questionable/obsolete, remove it.

(As we move into T5055, I expect to provide better tools for bundling/managing external dependencies.)

Test Plan

Ran arc, same as the old arc.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision is now accepted and ready to land.Sep 20 2018, 12:17 AM
This revision was automatically updated to reflect the committed changes.