D19896.id47557.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D19896.id47557.diff
View Options

	diff --git a/src/applications/legalpad/controller/LegalpadDocumentSignController.php b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
	--- a/src/applications/legalpad/controller/LegalpadDocumentSignController.php
	+++ b/src/applications/legalpad/controller/LegalpadDocumentSignController.php
	@@ -151,21 +151,6 @@
	$errors = array();
	$hisec_token = null;
	if ($request->isFormOrHisecPost() && !$has_signed) {
	-
	- // Require two-factor auth to sign legal documents.
	- if ($viewer->isLoggedIn()) {
	- $workflow_key = sprintf(
	- 'legalpad.sign(%s)',
	- $document->getPHID());
	-
	- $hisec_token = id(new PhabricatorAuthSessionEngine())
	- ->setWorkflowKey($workflow_key)
	- ->requireHighSecurityToken(
	- $viewer,
	- $request,
	- $document->getURI());
	- }
	-
	list($form_data, $errors, $field_errors) = $this->readSignatureForm(
	$document,
	$request);
	@@ -192,6 +177,20 @@
	$signature->setVerified($verified);

	if (!$errors) {
	+ // Require MFA to sign legal documents.
	+ if ($viewer->isLoggedIn()) {
	+ $workflow_key = sprintf(
	+ 'legalpad.sign(%s)',
	+ $document->getPHID());
	+
	+ $hisec_token = id(new PhabricatorAuthSessionEngine())
	+ ->setWorkflowKey($workflow_key)
	+ ->requireHighSecurityToken(
	+ $viewer,
	+ $request,
	+ $document->getURI());
	+ }
	+
	$signature->save();

	// If the viewer is logged in, signing for themselves, send them to