Page MenuHomePhabricator
Files F15474858

D18350.id44104.diff
No OneTemporary
Actions

D18350.id44104.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@
'names' => array(
'conpherence.pkg.css' => 'e68cf1fa',
'conpherence.pkg.js' => 'b5b51108',
- 'core.pkg.css' => 'cc0772c6',
+ 'core.pkg.css' => '04da74af',
'core.pkg.js' => '5d80e0db',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e',
@@ -149,7 +149,7 @@
'rsrc/css/phui/phui-comment-form.css' => 'ac68149f',
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
- 'rsrc/css/phui/phui-curtain-view.css' => '55dd0e59',
+ 'rsrc/css/phui/phui-curtain-view.css' => 'ca363f15',
'rsrc/css/phui/phui-document-pro.css' => '8af7ea27',
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
'rsrc/css/phui/phui-document.css' => 'c32e8dec',
@@ -835,7 +835,7 @@
'phui-comment-form-css' => 'ac68149f',
'phui-comment-panel-css' => 'f50152ad',
'phui-crumbs-view-css' => '6ece3bbb',
- 'phui-curtain-view-css' => '55dd0e59',
+ 'phui-curtain-view-css' => 'ca363f15',
'phui-document-summary-view-css' => '9ca48bdf',
'phui-document-view-css' => 'c32e8dec',
'phui-document-view-pro-css' => '8af7ea27',
diff --git a/src/view/layout/PHUICurtainView.php b/src/view/layout/PHUICurtainView.php
--- a/src/view/layout/PHUICurtainView.php
+++ b/src/view/layout/PHUICurtainView.php
@@ -46,10 +46,17 @@
$panels = $this->renderPanels();
- return id(new PHUIObjectBoxView())
+ $box = id(new PHUIObjectBoxView())
->appendChild($action_list)
->appendChild($panels)
->addClass('phui-two-column-properties');
+
+ // We want to hide this UI on mobile if there are no child panels
+ if (!$panels) {
+ $box->addClass('curtain-no-panels');
+ }
+
+ return $box;
}
private function renderPanels() {
diff --git a/webroot/rsrc/css/phui/phui-curtain-view.css b/webroot/rsrc/css/phui/phui-curtain-view.css
--- a/webroot/rsrc/css/phui/phui-curtain-view.css
+++ b/webroot/rsrc/css/phui/phui-curtain-view.css
@@ -46,3 +46,7 @@
.phui-side-column .phui-curtain-panel-body .phui-tag-view {
white-space: pre-wrap;
}
+
+.device .curtain-no-panels {
+ display: none;
+}

File Metadata

Mime Type
text/plain
Expires
Mon, Apr 7, 1:01 PM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7725174
Default Alt Text
D18350.id44104.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility