D15716.id37867.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D15716.id37867.diff
View Options

	diff --git a/src/docs/user/cluster/cluster_databases.diviner b/src/docs/user/cluster/cluster_databases.diviner
	--- a/src/docs/user/cluster/cluster_databases.diviner
	+++ b/src/docs/user/cluster/cluster_databases.diviner
	@@ -302,7 +302,7 @@
	network).

	With the `--for-replica` flag, the `bin/storage dump` command creates dumps
	-with `--dump-slave`, which includes a `CHANGE MASTER` statement in the output.
	+with `--master-data`, which includes a `CHANGE MASTER` statement in the output.
	This may be helpful when initially setting up new replicas, as it can make it
	easier to change the binlog coordinates to the correct position for the dump.

	diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
	--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
	+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
	@@ -13,7 +13,7 @@
	array(
	'name' => 'for-replica',
	'help' => pht(
	- 'Add __--dump-slave__ to the __mysqldump__ command, '.
	+ 'Add __--master-data__ to the __mysqldump__ command, '.
	'generating a CHANGE MASTER statement in the output.'),
	),
	));
	@@ -57,7 +57,7 @@
	$argv[] = '--default-character-set=utf8';

	if ($args->getArg('for-replica')) {
	- $argv[] = '--dump-slave';
	+ $argv[] = '--master-data';
	}

	$argv[] = '-u';