Page MenuHomePhabricator

Use --master-data, not --dump-slave, in bin/storage dump

Authored by epriestley on Apr 14 2016, 9:52 PM.



These flags do slightly different things, I actually want --master-data here. My test databases are setup half-weird and work with either statement, which is why I missed this.

Test Plan

Ran a dump against master, got the right CHANGE MASTER statement with no warnings.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 37867.Apr 14 2016, 9:52 PM
epriestley retitled this revision from to Use --master-data, not --dump-slave, in bin/storage dump.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Apr 14 2016, 9:55 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 9:55 PM
This revision was automatically updated to reflect the committed changes.