Use --master-data, not --dump-slave, in bin/storage dump
ClosedPublic
Actions

Authored by epriestley on Apr 14 2016, 9:52 PM.

Details

Reviewers

Commits

rP7852ec16190f: Use --master-data, not --dump-slave, in bin/storage dump

Summary

These flags do slightly different things, I actually want --master-data here. My test databases are setup half-weird and work with either statement, which is why I missed this.

Test Plan

Ran a dump against master, got the right CHANGE MASTER statement with no warnings.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37867.Apr 14 2016, 9:52 PM

epriestley retitled this revision from to Use --master-data, not --dump-slave, in bin/storage dump.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Apr 14 2016, 9:55 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 14 2016, 9:55 PM

Closed by commit rP7852ec16190f: Use --master-data, not --dump-slave, in bin/storage dump (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 9:56 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 15 2016, 12:09 AM

Revision Contents
Changeset List

Path

Size

src/

docs/

user/

cluster/

cluster_databases.diviner

2 lines

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementDumpWorkflow.php

4 lines

Diff 37868

View Options

src/docs/user/cluster/cluster_databases.diviner