Page MenuHomePhabricator

D19361.diff
No OneTemporary

D19361.diff

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -850,11 +850,13 @@
$revert_phids = array();
}
- $this->setUnmentionablePHIDMap(
- array_merge(
- $task_phids,
- $rev_phids,
- $revert_phids));
+ // See PHI574. Respect any unmentionable PHIDs which were set on the
+ // Editor by the caller.
+ $unmentionable_map = $this->getUnmentionablePHIDMap();
+ $unmentionable_map += $task_phids;
+ $unmentionable_map += $rev_phids;
+ $unmentionable_map += $revert_phids;
+ $this->setUnmentionablePHIDMap($unmentionable_map);
$result = array();
foreach ($edges as $type => $specs) {

File Metadata

Mime Type
text/plain
Expires
Fri, Apr 4, 10:59 AM (3 d, 5 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7385771
Default Alt Text
D19361.diff (912 B)

Event Timeline