Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15465357
D8216.id19554.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D8216.id19554.diff
View Options
Index: src/applications/differential/constants/DifferentialAction.php
===================================================================
--- src/applications/differential/constants/DifferentialAction.php
+++ src/applications/differential/constants/DifferentialAction.php
@@ -122,6 +122,7 @@
self::ACTION_ADDCCS => 'added CCs to',
self::ACTION_CLAIM => 'commandeered',
self::ACTION_REOPEN => 'reopened',
+ DifferentialTransaction::TYPE_INLINE => 'commented on',
);
if (!empty($verbs[$action])) {
Index: src/applications/differential/mail/DifferentialCommentMail.php
===================================================================
--- src/applications/differential/mail/DifferentialCommentMail.php
+++ src/applications/differential/mail/DifferentialCommentMail.php
@@ -154,6 +154,10 @@
$body[] = null;
foreach ($this->getComments() as $comment) {
+ if ($comment->getAction() == DifferentialTransaction::TYPE_INLINE) {
+ // These have comment content now, but are rendered below.
+ continue;
+ }
$content = $comment->getContent();
if (strlen($content)) {
$body[] = $this->formatText($content);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Apr 3, 5:46 PM (2 w, 5 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7730954
Default Alt Text
D8216.id19554.diff (1 KB)
Attached To
Mode
D8216: Fix double-rendering of inline comments in mail
Attached
Detach File
Event Timeline
Log In to Comment