D13856.id33461.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D13856.id33461.diff
View Options

	diff --git a/src/lint/linter/__tests__/xhpast/array-value.lint-test b/src/lint/linter/__tests__/xhpast/array-value.lint-test
	--- a/src/lint/linter/__tests__/xhpast/array-value.lint-test
	+++ b/src/lint/linter/__tests__/xhpast/array-value.lint-test
	@@ -16,12 +16,16 @@
	/* OPEN */ 1,
	/* CLOSED */ 2,
	);
	+
	+array('quack',
	+);
	~~~~~~~~~~
	warning:4:5
	warning:4:8
	warning:8:18
	warning:12:17
	warning:12:32
	+warning:20:7
	~~~~~~~~~~
	<?php

	@@ -46,3 +50,7 @@
	/* OPEN */ 1,
	/* CLOSED */ 2,
	);
	+
	+array(
	+'quack',
	+);
	diff --git a/src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php b/src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php
	--- a/src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php
	+++ b/src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php
	@@ -36,7 +36,7 @@
	list($before, $after) = $value->getSurroundingNonsemanticTokens();

	if (strpos(implode('', mpull($before, 'getValue')), "\n") === false) {
	- if (last($before)->isAnyWhitespace()) {
	+ if (last($before) && last($before)->isAnyWhitespace()) {
	$token = last($before);
	$replacement = "\n".$value->getIndentation();
	} else {