Differential D13856

Minor improvement for array value linter rule
ClosedPublic
Actions

Authored by joshuaspence on Aug 10 2015, 9:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC504ff4268188: Minor improvement for array value linter rule

Summary

This linter rule fails on multi-line arrays with no whitespace before the first array value. Specifically, the following exception is thrown:

Fatal error: Call to a member function isAnyWhitespace() on boolean in arcanist/src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php on line 40

Test Plan

Added another test case.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 33461.Aug 10 2015, 9:38 PM

joshuaspence retitled this revision from to Minor improvement for array value linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 10 2015, 9:38 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Aug 10 2015, 9:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 10 2015, 9:38 PM

Closed by commit rARC504ff4268188: Minor improvement for array value linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 10 2015, 9:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xhpast/

array-value.lint-test

8 lines

xhpast/

rules/

ArcanistArrayValueXHPASTLinterRule.php

2 lines

Diff 33463

View Options

src/lint/linter/tests/xhpast/array-value.lint-test

View Options

src/lint/linter/xhpast/rules/ArcanistArrayValueXHPASTLinterRule.php

Minor improvement for array value linter ruleClosedPublicActions