D18924.id45419.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D18924.id45419.diff
View Options

	diff --git a/resources/sql/patches/102.heraldcleanup.php b/resources/sql/patches/102.heraldcleanup.php
	--- a/resources/sql/patches/102.heraldcleanup.php
	+++ b/resources/sql/patches/102.heraldcleanup.php
	@@ -1,39 +1,8 @@
	<?php

	-echo pht('Cleaning up old Herald rule applied rows...')."\n";
	-$table = new HeraldRule();
	-$table->openTransaction();
	-$table->beginReadLocking();
	+// Once, this migration deleted some unnecessary rows written by Herald before
	+// January 2012. These rows don't hurt anything, they just cluttered up the
	+// database a bit.

	-$rules = $table->loadAll();
	-foreach ($rules as $key => $rule) {
	- $first_policy = HeraldRepetitionPolicyConfig::toInt(
	- HeraldRepetitionPolicyConfig::FIRST);
	- if ($rule->getRepetitionPolicy() != $first_policy) {
	- unset($rules[$key]);
	- }
	-}
	-
	-$conn_w = $table->establishConnection('w');
	-
	-$clause = '';
	-if ($rules) {
	- $clause = qsprintf(
	- $conn_w,
	- 'WHERE ruleID NOT IN (%Ld)',
	- mpull($rules, 'getID'));
	-}
	-
	-echo pht('This may take a moment')."\n";
	-do {
	- queryfx(
	- $conn_w,
	- 'DELETE FROM %T %Q LIMIT 1000',
	- HeraldRule::TABLE_RULE_APPLIED,
	- $clause);
	- echo '.';
	-} while ($conn_w->getAffectedRows());
	-
	-$table->endReadLocking();
	-$table->saveTransaction();
	-echo "\n".pht('Done.')."\n";
	+// The migration was removed in January 2018 to make maintenance on rule
	+// repetition policies easier.