Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15458080
D12786.id30734.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D12786.id30734.diff
View Options
diff --git a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
--- a/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
+++ b/src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
@@ -383,6 +383,8 @@
$this->getDisplayYearAndMonthAndDay($query);
$day_view = new PHUICalendarDayView(
+ $this->getDateFrom($query),
+ $this->getDateTo($query),
$start_year,
$start_month,
$start_day);
diff --git a/src/view/phui/calendar/PHUICalendarDayView.php b/src/view/phui/calendar/PHUICalendarDayView.php
--- a/src/view/phui/calendar/PHUICalendarDayView.php
+++ b/src/view/phui/calendar/PHUICalendarDayView.php
@@ -1,6 +1,8 @@
<?php
final class PHUICalendarDayView extends AphrontView {
+ private $rangeStart;
+ private $rangeEnd;
private $day;
private $month;
@@ -24,7 +26,16 @@
return $this->browseURI;
}
- public function __construct($year, $month, $day = null) {
+ public function __construct(
+ $range_start,
+ $range_end,
+ $year,
+ $month,
+ $day = null) {
+
+ $this->rangeStart = $range_start;
+ $this->rangeEnd = $range_end;
+
$this->day = $day;
$this->month = $month;
$this->year = $year;
@@ -160,10 +171,18 @@
$header = $this->renderDayViewHeader();
$sidebar = $this->renderSidebar();
+ $errors = array();
+
+ if ($day_start > $this->rangeEnd->getEpoch() ||
+ $day_start < $this->rangeStart->getEpoch()) {
+ $errors[] = pht('Day is out of query range');
+ }
+
$table_box = id(new PHUIObjectBoxView())
->setHeader($header)
->appendChild($all_day_event_box)
->appendChild($table)
+ ->setFormErrors($errors)
->setFlush(true);
$layout = id(new AphrontMultiColumnView())
@@ -277,8 +296,6 @@
private function renderDayViewHeader() {
$button_bar = null;
-
- // check for a browseURI, which means we need "fancy" prev / next UI
$uri = $this->getBrowseURI();
if ($uri) {
list($prev_year, $prev_month, $prev_day) = $this->getPrevDay();
@@ -312,8 +329,9 @@
}
- $day_of_week = $this->getDayOfWeek();
- $header_text = $this->getDateTime()->format('F j, Y');
+ $display_day = $this->getDateTime();
+ $day_of_week = id(clone $display_day)->format('l');
+ $header_text = id(clone $display_day)->format('F j, Y');
$header_text = $day_of_week.', '.$header_text;
$header = id(new PHUIHeaderView())
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Mar 31, 8:41 PM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7728367
Default Alt Text
D12786.id30734.diff (2 KB)
Attached To
Mode
D12786: Calendar day view should notify user if they have navigated away from the query range dates.
Attached
Detach File
Event Timeline
Log In to Comment