Paths

Table of Contentst

Differential D12786

Calendar day view should notify user if they have navigated away from the query range dates.
ClosedPublic
Actions

Authored by lpriestley on May 9 2015, 8:13 PM.

Tags

None

Referenced Files

	F15476498: D12786.id30734.diff
	Mon, Apr 7, 6:37 AM

	F15458757: D12786.id30735.diff
	Mon, Mar 31, 6:43 AM

	F15458236: D12786.id30737.diff
	Sun, Mar 30, 10:03 PM

	F15458080: D12786.id30734.diff
	Sun, Mar 30, 8:41 PM

	F15456971: D12786.id.diff
	Sun, Mar 30, 1:24 PM

	F15453678: D12786.diff
	Sat, Mar 29, 1:31 PM

	F15435457: D12786.id30736.diff
	Tue, Mar 25, 8:26 AM

	F15379909: D12786.id30735.diff
	Fri, Mar 14, 12:13 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8104: Viewer should be notified if viewed "day view" or "month view" is out of the selected query range.

Commits

Restricted Diffusion Commit
rPb67ad3c4e06a: Calendar day view should notify user if they have navigated away from the…

Summary

Ref T8104, Calendar day view should notify user if they have navigated away from the query range dates.

Test Plan

Open Calendar day view, choose May 12-13 range, execute query, page through to May 11, day view should show error that day is out of range.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30734.May 9 2015, 8:13 PM

lpriestley retitled this revision from to Calendar day view should notify user if they have navigated away from the query range dates..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8104: Viewer should be notified if viewed "day view" or "month view" is out of the selected query range. .

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 9 2015, 8:13 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Adding "part of day is out of range" errors

epriestley accepted this revision.May 9 2015, 8:52 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/view/phui/calendar/PHUICalendarDayView.php
346–348	I think you can just: $header_text = $display_day->format('l, F j, y'); The `clone` shouldn't be necessary because `format()` doesn't modify the object.
434–435	Does this still have callers?

This revision is now accepted and ready to land.May 9 2015, 8:52 PM

date format cleanup

Closed by commit rPb67ad3c4e06a: Calendar day view should notify user if they have navigated away from the… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 9 2015, 9:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

2 lines

view/

phui/

calendar/

PHUICalendarDayView.php

50 lines

Diff 30737

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...

src/view/phui/calendar/PHUICalendarDayView.php

Loading...