Page MenuHomePhabricator
Differential D20153

Clean up final `setQueryParams()` callsites
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 9:23 PM.
Tags
None
Referenced Files
F22559724: D20153.id48160.diff
Thu, Sep 24, 1:06 AM
F22517771: D20153.diff
Sun, Sep 20, 10:32 AM
Unknown Object (File)
Aug 23 2026, 9:52 PM
Unknown Object (File)
Jun 19 2026, 8:41 PM
Unknown Object (File)
May 29 2026, 2:43 PM
Unknown Object (File)
Apr 5 2026, 5:58 AM
Unknown Object (File)
Apr 5 2026, 5:54 AM
Unknown Object (File)
Apr 5 2026, 5:53 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
Commits
rP241f06c9ffc6: Clean up final `setQueryParams()` callsites
Summary

Ref T13250. See D20149.

Test Plan

All trivial?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2019, 9:23 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2019, 9:24 PM
Harbormaster failed remote builds in B21963: Diff 48119!
epriestley requested review of this revision.Feb 12 2019, 9:24 PM

Depends on D20149.

amckinley accepted this revision.Feb 14 2019, 7:32 PM
This revision is now accepted and ready to land.Feb 14 2019, 7:32 PM
Closed by commit rP241f06c9ffc6: Clean up final `setQueryParams()` callsites (authored by epriestley). · Explain WhyFeb 14 2019, 7:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
5 lines
response/
2 lines
applications/
auth/
provider/
2 lines
files/
controller/
2 lines

Diff 48160

View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/aphront/response/AphrontResponse.php

Loading...
View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
Phabricator · Built by Phacility