Page MenuHomePhabricator
Files F15447679

D14881.diff
No OneTemporary
Actions

D14881.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -8,7 +8,7 @@
return array(
'names' => array(
'core.pkg.css' => 'a419cf4b',
- 'core.pkg.js' => '2a50ac55',
+ 'core.pkg.js' => '400453e4',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '2de124c9',
'differential.pkg.js' => '64e69521',
@@ -452,7 +452,7 @@
'rsrc/js/core/DragAndDropFileUpload.js' => 'ad10aeac',
'rsrc/js/core/DraggableList.js' => 'a16ec1c6',
'rsrc/js/core/FileUpload.js' => '477359c8',
- 'rsrc/js/core/Hovercard.js' => '88e3466d',
+ 'rsrc/js/core/Hovercard.js' => 'c6f720ff',
'rsrc/js/core/KeyboardShortcut.js' => '1ae869f2',
'rsrc/js/core/KeyboardShortcutManager.js' => 'c1700f6f',
'rsrc/js/core/MultirowRowManager.js' => 'b5d57730',
@@ -747,7 +747,7 @@
'phabricator-file-upload' => '477359c8',
'phabricator-filetree-view-css' => 'fccf9f82',
'phabricator-flag-css' => '5337623f',
- 'phabricator-hovercard' => '88e3466d',
+ 'phabricator-hovercard' => 'c6f720ff',
'phabricator-hovercard-view-css' => '1239cd52',
'phabricator-keyboard-shortcut' => '1ae869f2',
'phabricator-keyboard-shortcut-manager' => 'c1700f6f',
@@ -1461,13 +1461,6 @@
'javelin-stratcom',
'javelin-dom',
),
- '88e3466d' => array(
- 'javelin-install',
- 'javelin-dom',
- 'javelin-vector',
- 'javelin-request',
- 'javelin-uri',
- ),
'88f0c5b3' => array(
'javelin-behavior',
'javelin-dom',
@@ -1780,6 +1773,13 @@
'javelin-dom',
'javelin-vector',
),
+ 'c6f720ff' => array(
+ 'javelin-install',
+ 'javelin-dom',
+ 'javelin-vector',
+ 'javelin-request',
+ 'javelin-uri',
+ ),
'c72aa091' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/src/infrastructure/customfield/field/PhabricatorCustomField.php b/src/infrastructure/customfield/field/PhabricatorCustomField.php
--- a/src/infrastructure/customfield/field/PhabricatorCustomField.php
+++ b/src/infrastructure/customfield/field/PhabricatorCustomField.php
@@ -506,7 +506,7 @@
$out = array();
foreach ($handles as $handle) {
- $out[] = $handle->renderLink();
+ $out[] = $handle->renderHovercardLink();
}
return phutil_implode_html(phutil_tag('br'), $out);
diff --git a/webroot/rsrc/js/core/Hovercard.js b/webroot/rsrc/js/core/Hovercard.js
--- a/webroot/rsrc/js/core/Hovercard.js
+++ b/webroot/rsrc/js/core/Hovercard.js
@@ -39,10 +39,11 @@
show : function(root, phid) {
var self = JX.Hovercard;
- // Already displaying
- if (self.getCard() && phid == self._visiblePHID) {
+
+ if (root === this._activeRoot) {
return;
}
+
self.hide();
self._visiblePHID = phid;

File Metadata

Mime Type
text/plain
Expires
Sat, Mar 29, 12:57 AM (4 w, 18 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7448880
Default Alt Text
D14881.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility