Page MenuHomePhabricator
Differential D14881

Fix hovercard behavior for multiple copies of the same object
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 8:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 6:27 PM
Unknown Object (File)
Sat, Dec 7, 1:52 PM
Unknown Object (File)
Thu, Nov 28, 5:39 PM
Unknown Object (File)
Nov 20 2024, 1:05 PM
Unknown Object (File)
Nov 11 2024, 6:44 AM
Unknown Object (File)
Nov 10 2024, 12:17 PM
Unknown Object (File)
Nov 10 2024, 12:17 PM
Unknown Object (File)
Nov 6 2024, 12:53 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8980: Make hovecards activate for standard handle lists
Commits
Restricted Diffusion Commit
rPe0ad791247f6: Fix hovercard behavior for multiple copies of the same object
Summary

Ref T8980. Previously, if you had like T123 T123 T123 and waved your mouse over them, we wouldn't move the card. Now, move the card.

Test Plan

Waved mouse. Saw the card move.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35971.Dec 24 2015, 8:39 PM
epriestley retitled this revision from to Fix hovercard behavior for multiple copies of the same object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8980: Make hovecards activate for standard handle lists.
epriestley added a comment.Dec 24 2015, 8:41 PM

This mostly happened with stuff like:

Author: dog
Subscribers: dog

So you'd mouse over "Author", then move to "Subscribers" but the card wouldn't move.

epriestley updated this revision to Diff 35972.Dec 24 2015, 8:42 PM
  • BONUS! More hovercards!
chad accepted this revision.Dec 24 2015, 9:16 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 9:16 PM
Closed by commit rPe0ad791247f6: Fix hovercard behavior for multiple copies of the same object (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
infrastructure/
customfield/
field/
2 lines
webroot/
rsrc/
js/
core/
5 lines

Diff 35974

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...
View Options

webroot/rsrc/js/core/Hovercard.js

Loading...
Phabricator · Built by Phacility