Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15444145
D20587.id49108.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D20587.id49108.diff
View Options
diff --git a/src/applications/auth/engine/PhabricatorAuthSessionEngine.php b/src/applications/auth/engine/PhabricatorAuthSessionEngine.php
--- a/src/applications/auth/engine/PhabricatorAuthSessionEngine.php
+++ b/src/applications/auth/engine/PhabricatorAuthSessionEngine.php
@@ -485,7 +485,7 @@
// change the order of prompts for users, but the alternative is that the
// Settings panel order disagrees with the prompt order, which seems more
// disruptive.
- $factors = msort($factors, 'newSortVector');
+ $factors = msortv($factors, 'newSortVector');
// If the account has no associated multi-factor auth, just issue a token
// without putting the session into high security mode. This is generally
diff --git a/src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php b/src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
--- a/src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorExternalAccountsSettingsPanel.php
@@ -94,7 +94,7 @@
->setViewer($viewer)
->withIsEnabled(true)
->execute();
- $configs = msort($configs, 'getSortVector');
+ $configs = msortv($configs, 'getSortVector');
$account_map = mgroup($accounts, 'getProviderConfigPHID');
diff --git a/src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php b/src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php
--- a/src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php
+++ b/src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php
@@ -54,7 +54,7 @@
->setViewer($viewer)
->withUserPHIDs(array($user->getPHID()))
->execute();
- $factors = msort($factors, 'newSortVector');
+ $factors = msortv($factors, 'newSortVector');
$rows = array();
$rowc = array();
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Mar 28, 8:05 AM (3 d, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7720424
Default Alt Text
D20587.id49108.diff (1 KB)
Attached To
Mode
D20587: Fix more "msort()" vs "msortv()" callsites
Attached
Detach File
Event Timeline
Log In to Comment