Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15432189
D21592.id51407.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1005 B
Referenced Files
None
Subscribers
None
D21592.id51407.diff
View Options
diff --git a/src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php b/src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionAuthorTransaction.php
@@ -95,10 +95,20 @@
}
if ($is_foist) {
- return pht(
- '%s foisted this revision upon %s.',
- $this->renderAuthor(),
- $this->renderNewHandle());
+ if ($new_phid) {
+ return pht(
+ '%s foisted this revision upon %s.',
+ $this->renderAuthor(),
+ $this->renderNewHandle());
+ } else {
+
+ // This isn't a valid transaction that can be applied, but happens in
+ // the preview if you temporarily delete the tokenizer value.
+
+ return pht(
+ '%s foisted this revision upon...',
+ $this->renderAuthor());
+ }
}
return pht(
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 25, 4:41 PM (4 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7719793
Default Alt Text
D21592.id51407.diff (1005 B)
Attached To
Mode
D21592: Improve rendering behavior for "foist upon" with an empty tokenizer
Attached
Detach File
Event Timeline
Log In to Comment