Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15431565
D21406.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D21406.diff
View Options
diff --git a/src/applications/diffusion/controller/DiffusionCommitController.php b/src/applications/diffusion/controller/DiffusionCommitController.php
--- a/src/applications/diffusion/controller/DiffusionCommitController.php
+++ b/src/applications/diffusion/controller/DiffusionCommitController.php
@@ -183,7 +183,6 @@
}
$curtain = $this->buildCurtain($commit, $repository);
- $subheader = $this->buildSubheaderView($commit, $commit_data);
$details = $this->buildPropertyListView(
$commit,
$commit_data,
@@ -483,7 +482,6 @@
$view = id(new PHUITwoColumnView())
->setHeader($header)
- ->setSubheader($subheader)
->setCurtain($curtain)
->setMainColumn(
array(
@@ -760,52 +758,6 @@
return $view;
}
- private function buildSubheaderView(
- PhabricatorRepositoryCommit $commit,
- PhabricatorRepositoryCommitData $data) {
-
- $viewer = $this->getViewer();
- $drequest = $this->getDiffusionRequest();
- $repository = $drequest->getRepository();
-
- if ($repository->isSVN()) {
- return null;
- }
-
- $author_phid = $commit->getAuthorDisplayPHID();
- $author_name = $data->getAuthorName();
- $author_epoch = $data->getCommitDetail('authorEpoch');
- $date = null;
- if ($author_epoch !== null) {
- $date = phabricator_datetime($author_epoch, $viewer);
- }
-
- if ($author_phid) {
- $handles = $viewer->loadHandles(array($author_phid));
- $image_uri = $handles[$author_phid]->getImageURI();
- $image_href = $handles[$author_phid]->getURI();
- $author = $handles[$author_phid]->renderLink();
- } else if (strlen($author_name)) {
- $author = $author_name;
- $image_uri = null;
- $image_href = null;
- } else {
- return null;
- }
-
- $author = phutil_tag('strong', array(), $author);
- if ($date) {
- $content = pht('Authored by %s on %s.', $author, $date);
- } else {
- $content = pht('Authored by %s.', $author);
- }
-
- return id(new PHUIHeadThingView())
- ->setImage($image_uri)
- ->setImageHref($image_href)
- ->setContent($content);
- }
-
private function buildComments(PhabricatorRepositoryCommit $commit) {
$timeline = $this->buildTransactionTimeline(
$commit,
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 25, 1:09 PM (3 d, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7225324
Default Alt Text
D21406.diff (2 KB)
Attached To
Mode
D21406: Remove the "authored" subheader from commits
Attached
Detach File
Event Timeline
Log In to Comment