Page MenuHomePhabricator
Files F15431363

D17769.diff
No OneTemporary
Actions

D17769.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -155,7 +155,7 @@
'rsrc/css/phui/phui-form.css' => 'a5570f70',
'rsrc/css/phui/phui-head-thing.css' => 'fd311e5f',
'rsrc/css/phui/phui-header-view.css' => 'e082678d',
- 'rsrc/css/phui/phui-hovercard.css' => 'ae091fc5',
+ 'rsrc/css/phui/phui-hovercard.css' => 'df27a6c2',
'rsrc/css/phui/phui-icon-set-selector.css' => '87db8fee',
'rsrc/css/phui/phui-icon.css' => '12b387a1',
'rsrc/css/phui/phui-image-mask.css' => 'a8498f9c',
@@ -862,7 +862,7 @@
'phui-head-thing-view-css' => 'fd311e5f',
'phui-header-view-css' => 'e082678d',
'phui-hovercard' => '1bd28176',
- 'phui-hovercard-view-css' => 'ae091fc5',
+ 'phui-hovercard-view-css' => 'df27a6c2',
'phui-icon-set-selector-css' => '87db8fee',
'phui-icon-view-css' => '12b387a1',
'phui-image-mask-css' => 'a8498f9c',
diff --git a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
--- a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
+++ b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
@@ -24,24 +24,52 @@
$task,
$data) {
$viewer = $this->getViewer();
+ require_celerity_resource('phui-workcard-view-css');
- $hovercard
- ->setTitle($task->getMonogram())
- ->setDetail($task->getTitle());
+ $id = $task->getID();
+ $task = id(new ManiphestTaskQuery())
+ ->setViewer($viewer)
+ ->withIDs(array($id))
+ ->needProjectPHIDs(true)
+ ->executeOne();
+ $phids = array();
$owner_phid = $task->getOwnerPHID();
if ($owner_phid) {
- $owner = $viewer->renderHandle($owner_phid);
- } else {
- $owner = phutil_tag('em', array(), pht('None'));
+ $phids[$owner_phid] = $owner_phid;
+ }
+ foreach ($task->getProjectPHIDs() as $phid) {
+ $phids[$phid] = $phid;
+ }
+
+ $handles = $viewer->loadHandles($phids);
+ $handles = iterator_to_array($handles);
+
+ $card = id(new ProjectBoardTaskCard())
+ ->setViewer($viewer)
+ ->setTask($task)
+ ->setCanEdit(false);
+
+ $owner_phid = $task->getOwnerPHID();
+ if ($owner_phid) {
+ $owner_handle = $handles[$owner_phid];
+ $card->setOwner($owner_handle);
+ }
+
+ $project_phids = $task->getProjectPHIDs();
+ $project_handles = array_select_keys($handles, $project_phids);
+ if ($project_handles) {
+ $card->setProjectHandles($project_handles);
}
- $hovercard->addField(pht('Assigned To'), $owner);
- $hovercard->addField(
- pht('Priority'),
- ManiphestTaskPriority::getTaskPriorityName($task->getPriority()));
+ $item = $card->getItem();
+ $card = id(new PHUIObjectItemListView())
+ ->setFlush(true)
+ ->setItemClass('phui-workcard')
+ ->addClass('hovercard-task-view')
+ ->addItem($item);
+ $hovercard->appendChild($card);
- $hovercard->addTag(ManiphestView::renderTagForTask($task));
}
}
diff --git a/webroot/rsrc/css/phui/phui-hovercard.css b/webroot/rsrc/css/phui/phui-hovercard.css
--- a/webroot/rsrc/css/phui/phui-hovercard.css
+++ b/webroot/rsrc/css/phui/phui-hovercard.css
@@ -105,3 +105,7 @@
.phui-hovercard-tail a.button {
margin: 3px;
}
+
+.phui-hovercard-wrapper .hovercard-task-view {
+ box-shadow: 0px 4px 16px rgba(0,0,0,.2);
+}

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 11:56 AM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7711326
Default Alt Text
D17769.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility