Page MenuHomePhabricator

New hovercard UI for Maniphest Tasks
ClosedPublic

Authored by chad on Apr 22 2017, 8:57 PM.
Tags
None
Referenced Files
F13039228: D17769.diff
Tue, Apr 16, 5:41 AM
Unknown Object (File)
Thu, Apr 11, 8:14 AM
Unknown Object (File)
Thu, Apr 11, 7:13 AM
Unknown Object (File)
Sun, Mar 31, 11:12 AM
Unknown Object (File)
Mar 10 2024, 2:35 AM
Unknown Object (File)
Feb 18 2024, 2:20 PM
Unknown Object (File)
Feb 3 2024, 3:40 PM
Unknown Object (File)
Jan 22 2024, 6:59 PM
Subscribers

Details

Summary

Swaps out hovercard boring view for super cool workboard card view. Will have more diffs to add additional information down the road.

Test Plan

pasted_file (534×1 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
65–72

I can't seem to force a render here, any suggestions?

$card is a ProjectBoardTaskCard, which isn't a View, so you can't render it (it's just a structural object which represents a card, not an actual view of a card).

You can use getItem() to get a View (a PHUIObjectItemView) from it:

$view = $card->getItem();
$hovercard->appendChild($view);

With that change, I get this locally:

Screen Shot 2017-04-23 at 8.15.06 AM.png (563×1 px, 55 KB)

you can have this back :3

This revision now requires changes to proceed.Apr 23 2017, 3:16 PM

I think my high-quality local test data really bestows an aura of authority and authenticity upon it.

thanks for the test url reminder

Yeah, I had to dig it up myself. I'm not sure how to make it more obvious -- I guess we could put a little link or something on cards in development mode? Not sure how far down the path of "stuff is different in dev and production" we want to go.

chad edited edge metadata.
  • updated

I dropped the cover file for now. I want to figure out some treatment for the tags (and what workboards they are on, but looks like that wasn't abstracted out of Curtains, so I'll have to build that first.

chad edited the test plan for this revision. (Show Details)

Nice, definitely feels like an improvement.

This revision is now accepted and ready to land.Apr 24 2017, 12:28 AM
This revision was automatically updated to reflect the committed changes.