Page MenuHomePhabricator
Files F15431348

D20189.id48217.diff
No OneTemporary
Actions

D20189.id48217.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,8 +11,8 @@
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => '261ee8cf',
'core.pkg.js' => '5ace8a1e',
- 'differential.pkg.css' => '801c5653',
- 'differential.pkg.js' => '1f211736',
+ 'differential.pkg.css' => 'fcc82bc0',
+ 'differential.pkg.js' => '0e2b0e2c',
'diffusion.pkg.css' => '42c75c37',
'diffusion.pkg.js' => '91192d85',
'maniphest.pkg.css' => '35995d6d',
@@ -61,7 +61,7 @@
'rsrc/css/application/dashboard/dashboard.css' => '4267d6c6',
'rsrc/css/application/diff/inline-comment-summary.css' => '81eb368d',
'rsrc/css/application/differential/add-comment.css' => '7e5900d9',
- 'rsrc/css/application/differential/changeset-view.css' => '8a997ed9',
+ 'rsrc/css/application/differential/changeset-view.css' => '58236820',
'rsrc/css/application/differential/core.css' => 'bdb93065',
'rsrc/css/application/differential/phui-inline-comment.css' => '48acce5b',
'rsrc/css/application/differential/revision-comment.css' => '7dbc8d1d',
@@ -420,7 +420,7 @@
'rsrc/js/application/releeph/releeph-preview-branch.js' => '75184d68',
'rsrc/js/application/releeph/releeph-request-state-change.js' => '9f081f05',
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'aa3a100c',
- 'rsrc/js/application/repository/repository-crossreference.js' => 'db0c0214',
+ 'rsrc/js/application/repository/repository-crossreference.js' => 'c15122b4',
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e5bdb730',
'rsrc/js/application/search/behavior-reorder-queries.js' => 'b86f297f',
'rsrc/js/application/transactions/behavior-comment-actions.js' => '4dffaeb2',
@@ -541,7 +541,7 @@
'conpherence-thread-manager' => 'aec8e38c',
'conpherence-transaction-css' => '3a3f5e7e',
'd3' => 'd67475f5',
- 'differential-changeset-view-css' => '8a997ed9',
+ 'differential-changeset-view-css' => '58236820',
'differential-core-view-css' => 'bdb93065',
'differential-revision-add-comment-css' => '7e5900d9',
'differential-revision-comment-css' => '7dbc8d1d',
@@ -671,7 +671,7 @@
'javelin-behavior-reorder-applications' => 'aa371860',
'javelin-behavior-reorder-columns' => '8ac32fd9',
'javelin-behavior-reorder-profile-menu-items' => 'e5bdb730',
- 'javelin-behavior-repository-crossreference' => 'db0c0214',
+ 'javelin-behavior-repository-crossreference' => 'c15122b4',
'javelin-behavior-scrollbar' => '92388bae',
'javelin-behavior-search-reorder-queries' => 'b86f297f',
'javelin-behavior-select-content' => 'e8240b50',
@@ -1380,6 +1380,9 @@
'javelin-vector',
'javelin-typeahead-static-source',
),
+ 58236820 => array(
+ 'phui-inline-comment-view-css',
+ ),
'5902260c' => array(
'javelin-util',
'javelin-magical-init',
@@ -1587,9 +1590,6 @@
'8a16f91b' => array(
'syntax-default-css',
),
- '8a997ed9' => array(
- 'phui-inline-comment-view-css',
- ),
'8ac32fd9' => array(
'javelin-behavior',
'javelin-stratcom',
@@ -1912,6 +1912,12 @@
'c03f2fb4' => array(
'javelin-install',
),
+ 'c15122b4' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-stratcom',
+ 'javelin-uri',
+ ),
'c2c500a7' => array(
'javelin-install',
'javelin-dom',
@@ -2008,12 +2014,6 @@
'javelin-uri',
'phabricator-notification',
),
- 'db0c0214' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-stratcom',
- 'javelin-uri',
- ),
'dfa1d313' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php b/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
--- a/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
+++ b/src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
@@ -301,11 +301,6 @@
}
}
- // NOTE: This is a unicode zero-width space, which we use as a hint when
- // intercepting 'copy' events to make sure sensible text ends up on the
- // clipboard. See the 'phabricator-oncopy' behavior.
- $zero_space = "\xE2\x80\x8B";
-
$old_number = phutil_tag(
'td',
array(
@@ -330,10 +325,7 @@
phutil_tag(
'td',
array('class' => $n_classes, 'colspan' => $n_colspan),
- array(
- phutil_tag('span', array('class' => 'zwsp'), $zero_space),
- $n_text,
- )),
+ $n_text),
$n_cov,
));
diff --git a/webroot/rsrc/css/application/differential/changeset-view.css b/webroot/rsrc/css/application/differential/changeset-view.css
--- a/webroot/rsrc/css/application/differential/changeset-view.css
+++ b/webroot/rsrc/css/application/differential/changeset-view.css
@@ -67,11 +67,6 @@
padding: 1px 4px;
}
-.differential-diff td .zwsp {
- position: absolute;
- width: 0;
-}
-
.prose-diff {
padding: 12px 0;
white-space: pre-wrap;
diff --git a/webroot/rsrc/js/application/repository/repository-crossreference.js b/webroot/rsrc/js/application/repository/repository-crossreference.js
--- a/webroot/rsrc/js/application/repository/repository-crossreference.js
+++ b/webroot/rsrc/js/application/repository/repository-crossreference.js
@@ -237,11 +237,6 @@
}
var content = '' + node.textContent;
-
- // Strip off any ZWS characters. These are marker characters used to
- // improve copy/paste behavior.
- content = content.replace(/\u200B/g, '');
-
char += content.length;
}

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 11:52 AM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7693512
Default Alt Text
D20189.id48217.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility