Page MenuHomePhabricator
Files F15431053

D20330.diff
No OneTemporary
Actions

D20330.diff
View Options

diff --git a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
--- a/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
+++ b/src/applications/maniphest/engineextension/ManiphestHovercardEngineExtension.php
@@ -47,8 +47,7 @@
$card = id(new ProjectBoardTaskCard())
->setViewer($viewer)
- ->setTask($task)
- ->setCanEdit(false);
+ ->setTask($task);
$owner_phid = $task->getOwnerPHID();
if ($owner_phid) {
diff --git a/src/applications/project/engine/PhabricatorBoardRenderingEngine.php b/src/applications/project/engine/PhabricatorBoardRenderingEngine.php
--- a/src/applications/project/engine/PhabricatorBoardRenderingEngine.php
+++ b/src/applications/project/engine/PhabricatorBoardRenderingEngine.php
@@ -56,6 +56,7 @@
$card = id(new ProjectBoardTaskCard())
->setViewer($viewer)
->setTask($object)
+ ->setShowEditControls(true)
->setCanEdit($this->getCanEdit($phid));
$owner_phid = $object->getOwnerPHID();
diff --git a/src/applications/project/view/ProjectBoardTaskCard.php b/src/applications/project/view/ProjectBoardTaskCard.php
--- a/src/applications/project/view/ProjectBoardTaskCard.php
+++ b/src/applications/project/view/ProjectBoardTaskCard.php
@@ -6,6 +6,7 @@
private $projectHandles;
private $task;
private $owner;
+ private $showEditControls;
private $canEdit;
private $coverImageFile;
private $hideArchivedProjects;
@@ -70,6 +71,15 @@
return $this->canEdit;
}
+ public function setShowEditControls($show_edit_controls) {
+ $this->showEditControls = $show_edit_controls;
+ return $this;
+ }
+
+ public function getShowEditControls() {
+ return $this->showEditControls;
+ }
+
public function getItem() {
$task = $this->getTask();
$owner = $this->getOwner();
@@ -89,24 +99,26 @@
->setDisabled($task->isClosed())
->setBarColor($bar_color);
- if ($can_edit) {
- $card
- ->addSigil('draggable-card')
- ->addClass('draggable-card');
- $edit_icon = 'fa-pencil';
- } else {
- $card
- ->addClass('not-editable')
- ->addClass('undraggable-card');
- $edit_icon = 'fa-lock red';
- }
+ if ($this->getShowEditControls()) {
+ if ($can_edit) {
+ $card
+ ->addSigil('draggable-card')
+ ->addClass('draggable-card');
+ $edit_icon = 'fa-pencil';
+ } else {
+ $card
+ ->addClass('not-editable')
+ ->addClass('undraggable-card');
+ $edit_icon = 'fa-lock red';
+ }
- $card->addAction(
- id(new PHUIListItemView())
- ->setName(pht('Edit'))
- ->setIcon($edit_icon)
- ->addSigil('edit-project-card')
- ->setHref('/maniphest/task/edit/'.$task->getID().'/'));
+ $card->addAction(
+ id(new PHUIListItemView())
+ ->setName(pht('Edit'))
+ ->setIcon($edit_icon)
+ ->addSigil('edit-project-card')
+ ->setHref('/maniphest/task/edit/'.$task->getID().'/'));
+ }
if ($owner) {
$card->addHandleIcon($owner, $owner->getName());

File Metadata

Mime Type
text/plain
Expires
Tue, Mar 25, 10:14 AM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7223227
Default Alt Text
D20330.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility