Page MenuHomePhabricator

D7912.id.diff
No OneTemporary

D7912.id.diff

Index: src/applications/differential/mail/DifferentialCommentMail.php
===================================================================
--- src/applications/differential/mail/DifferentialCommentMail.php
+++ src/applications/differential/mail/DifferentialCommentMail.php
@@ -56,7 +56,10 @@
break;
}
- if (strlen(trim($comment->getContent()))) {
+ $has_comment = strlen(trim($comment->getContent()));
+ $has_inlines = (bool)$this->getInlineComments();
+
+ if ($has_comment || $has_inlines) {
switch ($action) {
case DifferentialAction::ACTION_CLOSE:
// Commit comments are auto-generated and not especially interesting,
@@ -68,6 +71,10 @@
}
}
+ if (!$tags) {
+ $tags[] = MetaMTANotificationType::TYPE_DIFFERENTIAL_OTHER;
+ }
+
return $tags;
}

File Metadata

Mime Type
text/plain
Expires
Mar 24 2025, 8:56 PM (4 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7348053
Default Alt Text
D7912.id.diff (833 B)

Event Timeline