D12391.id29785.diff
No OneTemporary
Actions

Size

1009 B

Referenced Files

None

Subscribers

None

D12391.id29785.diff
View Options

	diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
	--- a/src/lint/linter/ArcanistXHPASTLinter.php
	+++ b/src/lint/linter/ArcanistXHPASTLinter.php
	@@ -3459,6 +3459,10 @@

	foreach ($tokens as $token) {
	if ($token->isAnyWhitespace()) {
	+ if (strpos($token->getValue(), "\n") !== false) {
	+ continue;
	+ }
	+
	$this->raiseLintAtToken(
	$token,
	self::LINT_SELF_MEMBER_REFERENCE,
	diff --git a/src/lint/linter/__tests__/xhpast/self-member-references.lint-test b/src/lint/linter/__tests__/xhpast/self-member-references.lint-test
	--- a/src/lint/linter/__tests__/xhpast/self-member-references.lint-test
	+++ b/src/lint/linter/__tests__/xhpast/self-member-references.lint-test
	@@ -21,6 +21,9 @@
	}

	MyClass :: myMethod();
	+
	+SomeReallyLongClassName
	+ ::someMethod();
	~~~~~~~~~~
	error:3:7
	advice:7:5
	@@ -54,3 +57,6 @@
	}

	MyClass::myMethod();
	+
	+SomeReallyLongClassName
	+ ::someMethod();