Paths

Table of Contentst

Differential D12391

Minor improvement to self member reference linter rule
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 11:24 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARC51b5c70010de: Minor improvement to self member reference linter rule

Summary

Ref T7409. If :: is surrounded by whitespace tokens and the whitespace token contains a newline character, allow it.

Test Plan

Added test case.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29738.Apr 13 2015, 11:24 AM

joshuaspence retitled this revision from to Minor improvement to self member reference linter rule.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 11:24 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 13 2015, 2:27 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 2:27 PM

Closed by commit rARC51b5c70010de: Minor improvement to self member reference linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

4 lines

__tests__/

xhpast/

self-member-references.lint-test

6 lines

Diff 29785

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/self-member-references.lint-test

Minor improvement to self member reference linter ruleClosedPublicActions