D18772.id45046.diff
No OneTemporary
Actions

Size

909 B

Referenced Files

None

Subscribers

None

D18772.id45046.diff
View Options

	diff --git a/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php b/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
	--- a/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
	+++ b/src/applications/differential/xaction/DifferentialRevisionHoldDraftTransaction.php
	@@ -16,6 +16,15 @@

	public function applyInternalEffects($object, $value) {
	$object->setHoldAsDraft($value);
	+
	+ // If draft isn't the default state but we're creating a new revision
	+ // and holding it as a draft, put it in draft mode. See PHI206.
	+ // TODO: This can probably be removed once Draft is the universal default.
	+ if ($this->isNewObject()) {
	+ if ($object->isNeedsReview()) {
	+ $object->setModernRevisionStatus(DifferentialRevisionStatus::DRAFT);
	+ }
	+ }
	}

	public function getTitle() {