Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15425332
D12940.id31159.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D12940.id31159.diff
View Options
diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -200,7 +200,7 @@
$state,
$phid);
}
- return;
+ break;
}
return parent::applyBuiltinExternalTransaction($object, $xaction);
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -609,7 +609,7 @@
$state,
$phid);
}
- return;
+ break;
}
return parent::applyBuiltinExternalTransaction($object, $xaction);
diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
--- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php
@@ -163,11 +163,7 @@
PhabricatorLiskDAO $object,
PhabricatorApplicationTransaction $xaction) {
- $old = $xaction->getOldValue();
- $new = $xaction->getNewValue();
-
switch ($xaction->getTransactionType()) {
-
case PhabricatorTransactions::TYPE_EDGE:
$edge_type = $xaction->getMetadataValue('edge:type');
switch ($edge_type) {
@@ -220,7 +216,7 @@
}
break;
}
- return;
+ break;
}
return parent::applyBuiltinExternalTransaction($object, $xaction);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Mar 24, 4:10 AM (1 d, 4 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7717150
Default Alt Text
D12940.id31159.diff (1 KB)
Attached To
Mode
D12940: Transactions - fix bug adding people to projects
Attached
Detach File
Event Timeline
Log In to Comment