Page MenuHomePhabricator

D16480.id39654.diff
No OneTemporary

D16480.id39654.diff

diff --git a/src/applications/harbormaster/engine/HarbormasterBuildEngine.php b/src/applications/harbormaster/engine/HarbormasterBuildEngine.php
--- a/src/applications/harbormaster/engine/HarbormasterBuildEngine.php
+++ b/src/applications/harbormaster/engine/HarbormasterBuildEngine.php
@@ -446,11 +446,14 @@
if ($build->getBuildStatus() != HarbormasterBuildStatus::STATUS_PASSED) {
$all_pass = false;
}
- $any_fail = in_array($build->getBuildStatus(), array(
+ if (in_array($build->getBuildStatus(), array(
HarbormasterBuildStatus::STATUS_FAILED,
HarbormasterBuildStatus::STATUS_ERROR,
HarbormasterBuildStatus::STATUS_DEADLOCKED,
- ));
+ ))) {
+
+ $any_fail = true;
+ }
}
if ($any_fail) {

File Metadata

Mime Type
text/plain
Expires
Sun, Mar 23, 9:17 PM (1 d, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7390617
Default Alt Text
D16480.id39654.diff (795 B)

Event Timeline